Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending calendarize in TYPO3 12.4 broken #153

Closed
hannesbochmann opened this issue Nov 29, 2023 · 4 comments · Fixed by #155
Closed

Extending calendarize in TYPO3 12.4 broken #153

hannesbochmann opened this issue Nov 29, 2023 · 4 comments · Fixed by #155
Assignees
Labels

Comments

@hannesbochmann
Copy link
Contributor

In a TYPO3 12.4 with calendarize I get the following error which breaks the whole environment:

Class "TYPO3\CMS\Extbase\Object\Container\Container" not found in ext_localconf.php line 103

One thing is to fix extending the calendarize model which basically means just to remove the registerImplementation call. Another thing would be to make the extending optional. If you have a own extension of the event model only one can be used which is bad.

If it's okay for you I would add a extension configuration to enable extending calendarize which is disabled by default. And I would fix the extending itself.

@albig
Copy link
Collaborator

albig commented Nov 29, 2023

The support of calendarize in ods_osm with TYPO3 12.4 might be broken because there was no calendarize version compatible with TYPO3 12.4 as I released ods_osm 4.2..0 for TYPO3 12.

So yes, If you have a fix, this will be welcome.

@albig
Copy link
Collaborator

albig commented Dec 8, 2023

Thank you @hannesbochmann for your PR #154. This works of course.

When I was playing around with your fix, I wondered why I introduced extending the calendarize event model at all. It seems to work as is.

Could you verify my PR #155 works for you?

@hannesbochmann
Copy link
Contributor Author

@albig Yes, the PR works for me.

@albig
Copy link
Collaborator

albig commented Dec 8, 2023

Thank you. Than I merge this one and close yours.

@albig albig closed this as completed in #155 Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants