Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIXME fixes #37

Merged
merged 2 commits into from
Apr 26, 2024
Merged

FIXME fixes #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01e26c7
FIXME fixes
bobjacobsen Apr 10, 2024
af9ebf3
messageBytes not messagePart
bobjacobsen Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions openlcb/datagramservice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,7 @@ def handleDatagramRejected(self, message):
"Outstanding and replied-to memos don't match on rejected"
)

currentOutstandingMemo = None
# FIXME: unused currentOutstandingMemo. Is any code incomplete here?
self.currentOutstandingMemo = None

# fire the callback
memo.rejectedReply(memo)
Expand All @@ -232,8 +231,7 @@ def handleDatagramRejected(self, message):

def handleLinkQuiesce(self, message):
'''Link quiesced before outage: stop operation'''
quiesced = True
# FIXME: unused quiesced. Is any code incomplete here?
self.quiesced = True

def handleLinkRestarted(self, message):
'''Link restarted after outage:
Expand Down
3 changes: 1 addition & 2 deletions openlcb/tcplink/tcplink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,8 +145,7 @@ def forwardMessage(self, messageBytes, gatewayNodeID) : # not sure why gatewayN
destNodeID = None
data = messageBytes[8:]
if mti.addressPresent() :
destNodeID = NodeID(messagePart[8:13])
# FIXME: ^ messagePart is undefined. Slice data or messageBytes?
destNodeID = NodeID(messageBytes[8:13])
data = messageBytes[14:]
# and finally create the message
message = Message(mti, sourceNodeID, destNodeID, data)
Expand Down
Loading