feat: explicitly return invalid txs when simulate gasless bundle (#56)

bnb-chain · Oct 23, 2024 · d07ee29 · d07ee29
1 parent ceb1993
commit d07ee29
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/core/types/bundle_gasless.go b/core/types/bundle_gasless.go
@@ -15,6 +15,7 @@ type GaslessTxSimResult struct {
 }
 
 type SimulateGaslessBundleResp struct {
-	ValidResults     []GaslessTxSimResult
-	BasedBlockNumber int64
+	ValidResults      []GaslessTxSimResult
+	GasReachedResults []GaslessTxSimResult
+	BasedBlockNumber  int64
 }
diff --git a/miner/worker_builder.go b/miner/worker_builder.go
@@ -503,7 +503,8 @@ func (w *worker) simulateBundle(
 }
 
 func (w *worker) simulateGaslessBundle(env *environment, bundle *types.Bundle) (*types.SimulateGaslessBundleResp, error) {
-	result := make([]types.GaslessTxSimResult, 0)
+	validResults := make([]types.GaslessTxSimResult, 0)
+	gasReachedResults := make([]types.GaslessTxSimResult, 0)
 
 	txIdx := 0
 	for _, tx := range bundle.Txs {
@@ -520,19 +521,24 @@ func (w *worker) simulateGaslessBundle(env *environment, bundle *types.Bundle) (
 			env.state.RevertToSnapshot(snap)
 			env.gasPool.SetGas(gp)
 			log.Error("fail to simulate gasless tx, skipped", "hash", tx.Hash(), "err", err)
+
+			if err == core.ErrGasLimitReached {
+				gasReachedResults = append(gasReachedResults, types.GaslessTxSimResult{Hash: tx.Hash()})
+			}
 		} else {
 			txIdx++
 
-			result = append(result, types.GaslessTxSimResult{
+			validResults = append(validResults, types.GaslessTxSimResult{
 				Hash:    tx.Hash(),
 				GasUsed: receipt.GasUsed,
 			})
 		}
 	}
 
 	return &types.SimulateGaslessBundleResp{
-		ValidResults:     result,
-		BasedBlockNumber: env.header.Number.Int64(),
+		ValidResults:      validResults,
+		GasReachedResults: gasReachedResults,
+		BasedBlockNumber:  env.header.Number.Int64(),
 	}, nil
 }