New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EOF Validation stricter on returncontract codes #1618

Closed

rakita opened this issue Jul 15, 2024 · 1 comment

Labels

feature hf-prague

Member

rakita commented Jul 15, 2024

Validation needs to be stricter on RETURNCONTRACT code sections. These are new rules that were added.

We need to implement two additional validations:

RETURNCONTRACT the subcontainer pointed to deploy_container_index must not contain a RETURNCONTRACT instruction.
it is an error for a container to contain both RETURNCONTRACT and either of RETURN or STOP.
it is an error for a subcontainer to never be referenced in its parent container
it is an error for a given subcontainer to be referenced by both RETURNCONTRACT and EOFCREATE

PRs:
ipsilon/eof#135
ipsilon/eof#136

rakita mentioned this issue

Use cfg codesize limit for EOFCREATE #1580

Closed

rakita added feature hf-prague labels

rakita changed the title ~~EOF Validation stricker on returncontract codes~~ EOF Validation stricter on returncontract codes

Member Author

rakita commented Jul 29, 2024

done in #1648

rakita closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment