New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify docs about zero balances #1514

Open

mattsse opened this issue Jun 11, 2024 · 1 comment

Collaborator

mattsse commented Jun 11, 2024 •

edited

Loading

revm/crates/revm/src/db/states/state.rs

Lines 81 to 83 in 8742fc7

    
           /// Like [CacheAccount::increment_balance], this assumes that incremented balances are not 
        
           /// zero, and will not overflow once incremented. If using this to implement withdrawals, zero 
        
           /// balances must be filtered out before calling this function.

but 0 balances are skipped:

revm/crates/revm/src/db/states/state.rs

Lines 91 to 93 in 8742fc7

    
           if balance == 0 { 
        
               continue; 
        
           }

are the docs outdated @rakita ?

Member

rakita commented Jun 12, 2024

They are outdated, will remove them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment