-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename coinbase
to beneficiary
in BlockEnv
#1012
Comments
I would not break it rn but after the next release. And change is reasonable. Related to this: #916 |
Hey guys, sorry I saw the comment to hold on a bit late 😅 |
Lets close it, otherwise it will stay open for a few months, I apologize for the confusion |
Added this to this pull request #1209 |
Please revert those, there is no need to break it right now. |
Reverted |
Issue Description
Currently, in the
BlockEnv
of theprimitives
crate, the recipient of all gas spent within a block is referred to ascoinbase
:revm/crates/primitives/src/env.rs
Line 432 in b434308
To align with the latest yellow specifications and adhere to reth node standards, I propose renaming this field to
beneficiary
.Suggested Changes
coinbase
field tobeneficiary
in theBlockEnv
struct.Context
The suggested change is in line with the evolving standards in the Ethereum ecosystem, ensuring consistency and compliance with the latest specifications. This modification will improve clarity and maintain compatibility with the broader Ethereum development community.
The text was updated successfully, but these errors were encountered: