Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement bounded LRU map for peer known inv hashes #441

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement bounded LRU map for peer known inv hashes #441

wants to merge 3 commits into from

Conversation

dangershony
Copy link
Member

Add LruHashSet and use it in some behaviors, it will make sure the inv doesn't grow indefinitely

This solves CVE https://invdos.net/paper/CVE-2018-17145.pdf
And is based on bitcoin core bitcoin/bitcoin#2192
and ported from stratis node stratisproject/StratisFullNode@454e4d7

Thanks @zeptin

@dangershony
Copy link
Member Author

@sondreb please review this when you have a moment

@dangershony
Copy link
Member Author

@DavidGershony please review when you have a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGershony DavidGershony Awaiting requested review from DavidGershony

@sondreb sondreb Awaiting requested review from sondreb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dangershony