Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable the notification subscription. #435

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Disable the notification subscription. #435

wants to merge 2 commits into from

Conversation

dangershony
Copy link
Member

This class anyway is not working and waists p2p messages processing

The problem is described in this issue
#434

@dangershony
Copy link
Member Author

The BlockNotification class is a pretty old class that was used to notify light clients of blocks, it seill uses the old signal class.
Since then we have made refactoring to this area of the code, if we find we need to create notifications this has to be completely refactored and maybe use signalr

@dangershony
Copy link
Member Author

This code needs to be double checked in case the notification of transactions was used somehow in other places

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sondreb sondreb Awaiting requested review from sondreb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dangershony