Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding multisig wallet #354

Open
wants to merge 24 commits into
base: multisig-wallet
Choose a base branch
from
Open

Adding multisig wallet #354

wants to merge 24 commits into from

Commits on Sep 17, 2021

  1. Added multisig wallet

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    30b6405 View commit details
    Browse the repository at this point in the history

  2. Extracting root account interface so that it can be substituted 

    Extracting root account interface so that it can be substituted by multisig wallet classes
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    1cd6679 View commit details
    Browse the repository at this point in the history

  3. Extracting account interface so that it can be substituted 

    Extracting account interface so that it can be substituted by multisig wallet classes
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    3121132 View commit details
    Browse the repository at this point in the history

  4. Adding multisig scheme class

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    39459b3 View commit details
    Browse the repository at this point in the history

  5. Testing multisig address derivation

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    f8e60a4 View commit details
    Browse the repository at this point in the history

  6. Changing wallet class use interfaces instead of concrete classes

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    736a8a4 View commit details
    Browse the repository at this point in the history

  7. Integrating multisig wallet and interfaces into wallet manager

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    8480e28 View commit details
    Browse the repository at this point in the history

  8. Walletmanager should prefer dealing with interface based objects 

    WalletManager should prefer dealing with interface based objects , instead of concrete classes so that multiple variations of account and etc can be used
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    912b880 View commit details
    Browse the repository at this point in the history

  9. Refactoring to use interfaces instead of concrete classes.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    3762664 View commit details
    Browse the repository at this point in the history

  10. Refactoring to use interfaces instead of concrete classes. 

    Refactoring to use interfaces instead of concrete classes.
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    e49168f View commit details
    Browse the repository at this point in the history

  11. Refactoring to use interfaces instead of concrete classes 

    Added multisig wallet creation test
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    6f36959 View commit details
    Browse the repository at this point in the history

  12. Handling strange build problems.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    8b3b554 View commit details
    Browse the repository at this point in the history

  13. Handling strange build problems again

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    cb57401 View commit details
    Browse the repository at this point in the history

  14. Refactored to use interface collection instead of concreted class.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    65faa2d View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. Added create multisig wallet operation to IWalletManager interface.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f6a6ff8 View commit details
    Browse the repository at this point in the history

  2. Added explicit network parameter to GeneratePublicKey with default nu… 

    …ll to be backward compatible.
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    4326068 View commit details
    Browse the repository at this point in the history

  3. Created transaction hex response model for wallet RPCs.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    210650d View commit details
    Browse the repository at this point in the history

  4. Changed HD paths back to m/44' from m/45' as this was breaking privat… 

    …e key deriviation.
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    0e93ac6 View commit details
    Browse the repository at this point in the history

  5. Cleand up imports /usings.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    a5e4b00 View commit details
    Browse the repository at this point in the history

  6. Updated CreateMutisigWallet to use seed and xpubs as previous version… 

    … was reduced to just readonly multisig wallet.
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    982f81e View commit details
    Browse the repository at this point in the history

  7. Modified tests to verify private key + (n)xpub multisig wallet.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    978c3d9 View commit details
    Browse the repository at this point in the history

  8. Modified tests to verify private key + (n)xpub multisig wallet.

    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    5950514 View commit details
    Browse the repository at this point in the history

  9. Added RPCs to create multisig wallet, create multisig transctions, co… 

    …mbine signatures.
    @rodendron-xrhodium
    rodendron-xrhodium committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    a3e7c1e View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2022

  1. Bug fix for null LastBlockSynchedHash after creating new wallet

    @rodendron-xrhodium
    rodendron-xrhodium committed Jan 29, 2022
    Configuration menu
    Copy the full SHA
    f1b3066 View commit details
    Browse the repository at this point in the history