Get and set the cold state based on wallet.

[DennisAMenace]

This allows the for a better UX to know the Cold/Hot status of a wallet.

[dangershony]

Don't we have another way to know if its a hot or a cold wallet?

Actually it seems that after my change to the indexes its now possible to have the wallet as both hot and cold (if the funds are from another wallet)

This scenario sees to work:
Wallet A sends hot funds to Wallet B
and
Wallet B send hot funds to wallet A

[DennisAMenace]

Correct, but in the UI, they are not going to be hot AND cold at the same time, so only showing one interface to make the user experience better.

In the x42 wallet, I have this in the settings to change it to a hot wallet:

[dangershony]

@thecrypt0hunter your thoughts? shall we deliberately limit a wallet to be either hot or cold?

[thecrypt0hunter]

This is how it’s used logically, so yes I’d agree. Is there going to be an API that returns the wallet state (hot/cold) as well?

[dangershony]

When I think about it, the problem with this approach is that if the wallet is recovered then that flag is not known because its sort of a flag that is set by the user and not something that is discovered on the blockchain itself.

A much better approach will be to check if a hot/cold account has trx associated with it and that will determine what it is.

so a wallet becomes hot or cold based on the trx that is being setup.

If we do take this approach then we probably also need to check that flag when setting up a creating cold stake trx

[DennisAMenace]

Is there going to be an API that returns the wallet state (hot/cold) as well?

Yes, API is in this PR.

A much better approach will be to check if a hot/cold account has trx associated with it and that will determine what it is.

This would be great for setting the default value here on restore, but we still should have this feature so the user can have toggle hot/cold at will.

[dangershony]

Isn't this sufficient?
https://github.com/block-core/blockcore/blob/master/src/Features/Blockcore.Features.ColdStaking/Api/Models/ColdStakingModels.cs#L30

[thecrypt0hunter]

Can’t it be both hot and cold with that call? You would want it to be one or the other, but not both.

[sondreb]

A much better approach will be to check if a hot/cold account has trx associated with it and that will determine what it is.

Anyone can send a cold-staking activation to any address, so if I send to your hot-staking wallet, will we be able to filter and ensure this works properly?

[dangershony]

What about this PR? did we decide anything?