Skip to content

Update InitialBlockDownloadState.cs #553

Update InitialBlockDownloadState.cs

Update InitialBlockDownloadState.cs #553

Triggered via pull request March 18, 2024 15:14
Status Success
Total duration 49m 39s
Artifacts

pull-request.yml

on: pull_request
Matrix: buildAndUnitTest
Fit to window
Zoom out
Zoom in

Annotations

36 warnings
buildAndUnitTest (ubuntu-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
buildAndUnitTest (ubuntu-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
buildAndUnitTest (ubuntu-latest): src/Blockcore/NBitcoin/Crypto/Hashes.cs#L29
'SHA256Managed' is obsolete: 'Derived cryptographic types are obsolete. Use the Create method on the base type instead.' (https://aka.ms/dotnet-warnings/SYSLIB0021)
buildAndUnitTest (ubuntu-latest): src/Blockcore/NBitcoin/Bloom.cs#L191
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name
buildAndUnitTest (ubuntu-latest): src/Blockcore/AsyncWork/AsyncLoop.cs#L17
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (ubuntu-latest): src/Blockcore/Base/TimeSyncBehavior.cs#L82
Provide an overridable implementation of Dispose(bool) on 'TimeSyncBehaviorState' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (ubuntu-latest): src/Blockcore/NBitcoin/BitcoinStream.cs#L22
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (ubuntu-latest): src/Blockcore/Base/TipsManager.cs#L42
Provide an overridable implementation of Dispose(bool) on 'TipsManager' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (ubuntu-latest): src/Blockcore/Consensus/Chain/ChainRepository.cs#L22
Provide an overridable implementation of Dispose(bool) on 'ChainRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (ubuntu-latest): src/Blockcore/BlockPulling/BlockPuller.cs#L86
Provide an overridable implementation of Dispose(bool) on 'BlockPuller' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (ubuntu-latest): src/Blockcore/Builder/Feature/FullNodeFeature.cs#L56
Ensure that 'FullNodeFeature.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (windows-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
buildAndUnitTest (windows-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
buildAndUnitTest (windows-latest): src/Blockcore/NBitcoin/Crypto/Hashes.cs#L29
'SHA256Managed' is obsolete: 'Derived cryptographic types are obsolete. Use the Create method on the base type instead.' (https://aka.ms/dotnet-warnings/SYSLIB0021)
buildAndUnitTest (windows-latest): src/Blockcore/NBitcoin/Bloom.cs#L191
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name
buildAndUnitTest (windows-latest): src/Blockcore/AsyncWork/AsyncLoop.cs#L17
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (windows-latest): src/Blockcore/NBitcoin/BitcoinStream.cs#L22
Provide an overridable implementation of Dispose(bool) on 'Scope' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (windows-latest): src/Blockcore/P2P/PeerConnector.cs#L45
Provide an overridable implementation of Dispose(bool) on 'PeerConnector' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (windows-latest): src/Blockcore/P2P/Peer/NetworkPeer.cs#L103
Provide an overridable implementation of Dispose(bool) on 'NetworkPeer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (windows-latest): src/Blockcore/Consensus/Chain/ChainRepository.cs#L22
Provide an overridable implementation of Dispose(bool) on 'ChainRepository' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (windows-latest): src/Blockcore/P2P/Peer/NetworkPeerConnection.cs#L24
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerConnection' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (windows-latest): src/Blockcore/P2P/Peer/NetworkPeerDisposer.cs#L28
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerDisposer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (macos-latest)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, actions/setup-dotnet@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
buildAndUnitTest (macos-latest)
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-dotnet@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
buildAndUnitTest (macos-latest): src/Blockcore/NBitcoin/Crypto/Hashes.cs#L29
'SHA256Managed' is obsolete: 'Derived cryptographic types are obsolete. Use the Create method on the base type instead.' (https://aka.ms/dotnet-warnings/SYSLIB0021)
buildAndUnitTest (macos-latest): src/Blockcore/NBitcoin/Bloom.cs#L191
XML comment on 'Bloom.GetCompressedBloom()' has a paramref tag for 'maxSize', but there is no parameter by that name
buildAndUnitTest (macos-latest): src/Blockcore/P2P/Peer/NetworkPeer.cs#L103
Provide an overridable implementation of Dispose(bool) on 'NetworkPeer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (macos-latest): src/Blockcore/P2P/Peer/NetworkPeerConnection.cs#L24
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerConnection' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (macos-latest): src/Blockcore/P2P/Peer/NetworkPeerDisposer.cs#L28
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerDisposer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (macos-latest): src/Blockcore/P2P/Peer/NetworkPeerListener.cs#L13
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerListener' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (macos-latest): src/Blockcore/P2P/Peer/NetworkPeerServer.cs#L20
Provide an overridable implementation of Dispose(bool) on 'NetworkPeerServer' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (macos-latest): src/Blockcore/AsyncWork/AsyncLoop.cs#L17
Provide an overridable implementation of Dispose(bool) on 'AsyncLoop' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
buildAndUnitTest (macos-latest): src/Blockcore/P2P/PeerConnector.cs#L45
Provide an overridable implementation of Dispose(bool) on 'PeerConnector' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)