Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't see zsh-autosuggestions under Solarized theme #381

Closed
YujiShen opened this issue Nov 4, 2017 · 5 comments
Closed

Can't see zsh-autosuggestions under Solarized theme #381

YujiShen opened this issue Nov 4, 2017 · 5 comments
Labels
feature Feature requested by users RTT Ready to test on Test Flight
Milestone

Comments

@YujiShen
Copy link

YujiShen commented Nov 4, 2017

Under iTerm2 (macOS)
image

Under Blink
image

@willhbr
Copy link

willhbr commented Nov 5, 2017

I use zsh-autosuggestions in blink without any trouble. I’d guess you may have your ‘TERM’ set differently, or something similar?

@YujiShen
Copy link
Author

YujiShen commented Nov 5, 2017

@javanut13 I set TERM=xterm-256color, does this cause the problem? What should I set? Thanks!

I just test under both ssh and mosh, they are not working. But it is working when I use Termius under ssh on iOS.

@YujiShen
Copy link
Author

YujiShen commented Nov 5, 2017

I found this is a problem with themes. This Solarized one (preinstalled), can not see suggestions at all. Other themes works fine, although some of them are not very easy to see...

So I change the issue title.

@YujiShen YujiShen changed the title zsh-autosuggestions not working Can't see zsh-autosuggestions under Solarized theme Nov 5, 2017
@YujiShen
Copy link
Author

YujiShen commented Nov 5, 2017

Because Bright Black color is base03 which used by auto suggestions and is same as background color, so suggestions can not be seen. Refer to this issue mbadolato/iTerm2-Color-Schemes - Text gets invisible while running mocha.

I create a gist for patched theme, which change bright black to base01, and tweak the value of cursor. Here is the screenshot:

image

Is it possible to set cursor text color like iTerm?

@carloscabanero
Copy link
Member

Thanks for the Gist, I will apply it to next Blink. About changing cursor color font, this is an issue with HTerm and unfortunately they apply transparency. You can change the cursor color though in the cursor_color variable, make it brighter so that it contrasts better too.

This might be resolved if we move to xterm.js

@carloscabanero carloscabanero added the feature Feature requested by users label Nov 9, 2017
@carloscabanero carloscabanero added this to the Backlog milestone Nov 9, 2017
@yury yury added WIP Work In Progress RTT Ready to test on Test Flight and removed WIP Work In Progress labels Jan 24, 2018
@yury yury added WIP Work In Progress and removed RTT Ready to test on Test Flight labels Feb 26, 2018
@yury yury added RTT Ready to test on Test Flight and removed WIP Work In Progress labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Feature requested by users RTT Ready to test on Test Flight
Projects
None yet
Development

No branches or pull requests

4 participants