Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate special tag handling from cbor.Value to use cbor.TagSet #548

Closed
agaffney opened this issue Mar 17, 2024 · 0 comments · Fixed by #549
Closed

Migrate special tag handling from cbor.Value to use cbor.TagSet #548

agaffney opened this issue Mar 17, 2024 · 0 comments · Fixed by #549
Assignees
@agaffney

Comments

@agaffney
Copy link
Contributor

The fxamacker/cbor library has support for registering custom tag number handlers for encode/decode. We've been adding these special cases to cbor.Value, but we should make them available using the generic encode/decode wrappers without having to use cbor.Value. Create/add cbor.TagSet mappings for our custom types and add them to the encoder/decoder configs.
@agaffney agaffney self-assigned this Mar 17, 2024
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
9d93bdf 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
1b1ccf7 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
715d3c3 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
37c54aa 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
280fbbd 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
feeacd0 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
ee54023 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
36fb583 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
3aa6ae6 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
d34c40a 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
b93280b 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
76f4ef8 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
0873a5c 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
5c11a64 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
5acc60e 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
16b7a22 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
420ff88 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
5905ae1 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
f0716fe 
Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
e47c862 
This moves the handling for custom CBOR tag types from cbor.Value to the
generic encoder/decoder to make them more widely usable.

Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
855da70 
This moves the handling for custom CBOR tag types from cbor.Value to the
generic encoder/decoder to make them more widely usable.

Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
f58b168 
This moves the handling for some custom CBOR tag types from cbor.Value
to the generic encoder/decoder to make them more widely usable.

Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
77389e2 
This moves the handling for some custom CBOR tag types from cbor.Value
to the generic encoder/decoder to make them more widely usable.

Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
1d4bb43 
This moves the handling for some custom CBOR tag types from cbor.Value
to the generic encoder/decoder to make them more widely usable.

Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: custom CBOR tag handling
bc4f5e0 
This moves the handling for some custom CBOR tag types from cbor.Value
to the generic encoder/decoder to make them more widely usable.

Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: generic custom CBOR tag handling
549faa7 
This moves the handling for some custom CBOR tag types from cbor.Value
to the generic encoder/decoder to make them more widely usable.

Fixes #548
@agaffney agaffney mentioned this issue Mar 17, 2024
Merged
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: generic custom CBOR tag handling
4a663e2 
This moves the handling for some custom CBOR tag types from cbor.Value
to the generic encoder/decoder to make them more widely usable.

Fixes #548
agaffney added a commit that referenced this issue Mar 17, 2024
@agaffney
feat: generic custom CBOR tag handling (#549)
ef3e13e 
This moves the handling for some custom CBOR tag types from cbor.Value
to the generic encoder/decoder to make them more widely usable.

Fixes #548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agaffney agaffney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generic custom CBOR tag handling blinklabs-io/gouroboros
1 participant
@agaffney