Skip to content

Commit

Permalink
fix(address): normalize mixed-case Bech32 address before decoding
Browse files Browse the repository at this point in the history
Signed-off-by: Ales Verbic <verbotenj@blinklabs.io>
  • Loading branch information
verbotenj committed Oct 14, 2024
1 parent c442124 commit 9597e65
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ledger/common/address.go
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package common

import (
"fmt"
"strings"

"github.com/blinklabs-io/gouroboros/base58"
"github.com/blinklabs-io/gouroboros/bech32"
Expand Down Expand Up @@ -55,6 +56,7 @@ type Address struct {

// NewAddress returns an Address based on the provided bech32 address string
func NewAddress(addr string) (Address, error) {
addr = strings.ToLower(addr)
_, data, err := bech32.DecodeNoLimit(addr)
if err != nil {
return Address{}, err
Expand Down
14 changes: 14 additions & 0 deletions ledger/common/address_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import (
"testing"

"github.com/blinklabs-io/gouroboros/internal/test"
"github.com/stretchr/testify/assert"
)

func TestAddressFromBytes(t *testing.T) {
Expand Down Expand Up @@ -225,3 +226,16 @@ func TestAddressStakeAddress(t *testing.T) {
}
}
}

func TestAddressPaymentAddress_MixedCase(t *testing.T) {

lowerCaseAddress := "addr_test1qqawz5hm2tchtmarkfn2tamzvd2spatl89gtutgra6zwc3ktqj7p944ckc9lq7u36jrq99znwhzlq6jfv2j4ql92m4rq07hp8t"
laddr, err := NewAddress(lowerCaseAddress)
assert.Nil(t, err, "Expected no error when decoding a lowercase address")
// address with mixed case
mixedCaseAddress := "addr_test1QQawz5hm2tchtmarkfn2tamzvd2spatl89gtutgra6zwc3ktqj7p944ckc9lq7u36jrq99znwhzlq6jfv2j4ql92m4rq07hp8t"
addr, err := NewAddress(mixedCaseAddress)
assert.Nil(t, err, "Expected no error when decoding a mixed-case address")
assert.NotNil(t, addr, "Expected a valid address object after decoding")
assert.Equal(t, laddr.String(), addr.String(), "Expected the mixed-case address to be equal to lowercase")
}

0 comments on commit 9597e65

Please sign in to comment.