Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Update tracked object description optimistically #14490

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

hawkeye217
Copy link
Collaborator

Proposed change

When manually editing a tracked object description, mutation would sometimes not cause a refetch/revalidation. So this would cause a description to have stale data after closing/reopening the dialog.

This PR just calls mutate() with an optimistic state.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • The code has been formatted using Ruff (ruff format frigate)

Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit 7037b0e
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6716c423e040b30008d1dba8
😎 Deploy Preview https://deploy-preview-14490--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 merged commit b1285a1 into dev Oct 21, 2024
11 of 12 checks passed
@NickM-27 NickM-27 deleted the optimistic-update branch October 21, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants