Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redactwriter #181

Merged
merged 9 commits into from
Jun 14, 2023
Merged

redactwriter #181

merged 9 commits into from
Jun 14, 2023

Conversation

vshah23
Copy link
Contributor

@vshah23 vshah23 commented May 15, 2023 •
edited
Loading

Context

We want to make use of the Writer we use in the CLI for secret redaction in other places.

Changes

  • Copied the filterwriter from the Bitrise CLI and updated it to use go-utils/v2/Logger
  • Moved the mocks package from the analytics package to the root level
  • Added //go:build !race to filterwriter_test.go in order to prevent race detection during testing which made a test fail
  • Renamed the package and related files to redactwriter

@vshah23 vshah23 changed the title filterwriter redactwriter May 22, 2023
@vshah23 vshah23 mentioned this pull request May 25, 2023
Closed
2 tasks
@tothszabi tothszabi merged commit 35a7427 into master Jun 14, 2023
@tothszabi tothszabi deleted the filterwriter branch June 14, 2023 09:36
@tothszabi tothszabi mentioned this pull request Sep 8, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@godrei godrei godrei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vshah23 @godrei @tothszabi