Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Proposal: Add Flag --image-patterns to cmd #165

Open
panpan0000 opened this issue Jul 7, 2022 · 2 comments
Open

Feature Proposal: Add Flag --image-patterns to cmd #165

panpan0000 opened this issue Jul 7, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@panpan0000
Copy link

panpan0000 commented Jul 7, 2022

Currently , if we would like to enable relocateContainerImages=true feature to push image to target and modify the image repo in new helm chart, it requires the source helm chart has embeded .relok8s-images.yaml , like mariadb chart in https://charts.app-catalog.vmware.com/.

But unfortunately, NOT all helm charts have this file embeded, even the bitnami helm charts. Maybe only those charts in https://charts.app-catalog.vmware.com will include this file in the world.

The relok8s (https://github.com/vmware-tanzu/asset-relocation-tool-for-kubernetes) has a flag --image-patterns to specific an external .relok8s-images.yaml , which it's more friendly , not making it a hard requirement of source chart.

So design proposal: add --image-patterns :

People can create an external pattern file my-pattern.yaml (external means standalone, out of helm charts)

Usage

charts-syncer sync --image-patterns  my-pattern.yaml

In this way, every charts can be "relocated", not limited to those in catalog.vmware.com.

@panpan0000 panpan0000 changed the title Add Flag --image-patterns to cmd Feature Proposal: Add Flag --image-patterns to cmd Jul 7, 2022
@panpan0000
Copy link
Author

panpan0000 commented Jul 7, 2022

Hope this is can be fulfilled and make this open source tool more useful and friendly.
then we can have a my-pattern.yaml to cover all helm charts to be synced, instead of modify the helm packages which we cannot control.

@jotadrilo jotadrilo added the enhancement New feature or request label Aug 1, 2022
@HammerNL89
Copy link

Yes this would be a nice feature, currently I'm forced to use a separate tool for syncing the required images which adds complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants