Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 #56

Closed
r3h6 opened this issue Jul 2, 2018 · 6 comments
Closed

PHP 7.2 #56

r3h6 opened this issue Jul 2, 2018 · 6 comments
Assignees

Comments

@r3h6
Copy link

r3h6 commented Jul 2, 2018

Compatibility with PHP 7.2

@macjohnny
Copy link
Member

@r3h6 thanks for opening this issue. could you please add some information about problems that currently occur with PHP 7.2?

@maechler maechler self-assigned this Jul 2, 2018
@maechler
Copy link
Member

maechler commented Jul 2, 2018

Probably nothing except the version constraint in ext_emconf.php?

@r3h6
Copy link
Author

r3h6 commented Jul 2, 2018

So far none, just version constraint in composer

@maechler
Copy link
Member

maechler commented Jul 2, 2018

@r3h6 Actually there is no version constraint in the file composer.json:

"require": {
"typo3/cms-core": ">=6.2.0 <9.0.0"
},

See also requires on https://packagist.org/packages/bithost-gmbh/pdfviewhelpers#1.5.1

Is it possible that you use the TYPO3 composer repository (https://composer.typo3.org/) and that TYPO3 adds the PHP constraint based on ext_emconf.php?

We will definitely raise the requirement, but maybe you could solve the issue by getting the extension from Packagist.

@r3h6
Copy link
Author

r3h6 commented Jul 2, 2018

Version from packagist works fine, thanks

@r3h6 r3h6 closed this as completed Jul 2, 2018
@maechler
Copy link
Member

maechler commented Jul 2, 2018

I reopened this issue, because we will raise the version constraint in ext_emconf.php and probably also add it to composer.json.

@maechler maechler reopened this Jul 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants