Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TCPDF and FPDI source files from the extension #179

Closed
maechler opened this issue Nov 3, 2020 · 3 comments
Closed

Remove TCPDF and FPDI source files from the extension #179

maechler opened this issue Nov 3, 2020 · 3 comments

Comments

@maechler
Copy link
Member

maechler commented Nov 3, 2020

TCPDF and FPDI should be required as composer dependencies. For non-composer users we should add installation instructions to the documentation.

See also #178

@DanielSiepmann
Copy link

DanielSiepmann commented Sep 28, 2021

This doesn't need to be breaking.
The TER release can still contain the libraries as usual. E.g. check out https://github.com/tomasnorre/typo3-upload-ter#recommendation. The release is uploaded anyway, and can therefore be prepared accordingly. No need to document anything and move the heavy stuff to users.

Everyone who uses TER should probably get the bundled libraries, while everyone using composer should use composer instead.

Would be cool to get that into one of the next releases, so we can use composer patches to alter the libraries, instead of re implementing whole methods to add some small things.

Futher sources:

@maechler
Copy link
Member Author

@DanielSiepmann Thanks for sharing these resources! You are right, it does not need to be breaking as long as we still include the sources for the TER release. If this could be automated, that would be very handy of course!
I will have a look at this, however I am rather busy at the moment, I do not know when I will get to work on this.

@DanielSiepmann
Copy link

DanielSiepmann commented Sep 29, 2021

Thanks for fast response. I didn't publish anything to TER myself, that's why I won't provide a PR. Hope those resources help, and it will make it as none BC in the future. Don't feel pushed by my comments on that topic.

Let me know if I can help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants