Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render scale should scale all frame buffers respectively #160

Open
bitbrain opened this issue Oct 15, 2018 · 0 comments
Open

render scale should scale all frame buffers respectively #160

bitbrain opened this issue Oct 15, 2018 · 0 comments

Comments

@bitbrain
Copy link
Owner

bitbrain commented Oct 15, 2018

Currently, setting the renderScale in the game settings does not impact the framebuffer scale.

Things to keep in mind:

  • what's the impact of drawing (e.g. particle effects) onto scaled down frame buffers?

Major concern of this are mobile devices:

e.g. Samsung Galaxy S8 has a screen resolution of 2960 x 1440 pixels.

Given a render pipeline with multiple stages and shaders, this might add up:

2960 x 1440 pixels (base layer) + 2960 x 1440 pixels (frame buffer) + 2960 x 1440 pixels (end result) per frame!! This is insane. The idea is to reduce that load on the graphics chip drastically by applying the framebuffer scale (e.g. factor of x0.2):

2960 x 1440 pixels (base layer) + 592 x 288 pixels (frame buffer) + 592 x 288 pixels (end result) per frame!!

@bitbrain bitbrain added this to the Version 1.0.0 (Initial Release) milestone Oct 15, 2018
@bitbrain bitbrain modified the milestones: Version 1.0.0 (Initial Release), 0.6.0 Mar 11, 2019
@bitbrain bitbrain changed the title render scale should scale all pipeline frame buffers respectively render scale should scale all frame buffers respectively 🐛 Mar 11, 2019
@bitbrain bitbrain changed the title render scale should scale all frame buffers respectively 🐛 render scale should scale all frame buffers respectively Jul 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant