Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker and kubernetes configs #151

Merged
merged 2 commits into from
Sep 29, 2020
Merged

add docker and kubernetes configs #151

merged 2 commits into from
Sep 29, 2020

Conversation

ftsell
Copy link
Member

@ftsell ftsell commented Sep 24, 2020

I have added the docker configuration from git.mafiasi.de/mafiasi-ag/dockerfiles and kubernetes definitions from git.mafiasi.de/Server-AG/ansible to this repo itself.

Doing so enables others to use the Imagetagger in a more convenient way since it is openly documented how it can be deployed.

The changes were tested using a local minikube cluster and the production instance (imagetagger.bit-bots.de) already uses this new configuration as well.

Copy link
Member

@timonegk timonegk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change USE_NGINX_IMAGE_PROVISION and ENABLE_ZIP_DOWNLOAD in settings.py.example? I think both settings were more adequate before since they are not needed or confusing when the application is run in a simple setup with ./manage.py runserver, for example to check out the software.

@ftsell
Copy link
Member Author

ftsell commented Sep 28, 2020

Why change USE_NGINX_IMAGE_PROVISION and ENABLE_ZIP_DOWNLOAD in settings.py.example? I think both settings were more adequate before since they are not needed or confusing when the application is run in a simple setup with ./manage.py runserver, for example to check out the software.

Because the settings.py.example is now used as the in-docker default settings so that it more accurately reflects a working example an not some long-dead unmaintained file. I also think that by including a Dockerfile the simplest setup would be a docker run and not via manage.py

@ftsell
Copy link
Member Author

ftsell commented Sep 28, 2020

@timonegk I have added some changes to respect your suggestions in f413c16

@ftsell ftsell merged commit 6d7869c into master Sep 29, 2020
@ftsell ftsell deleted the feature/dockerfile branch September 29, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants