For Cycle 8

[julianknutsen]

Summary

Specify the total amount of BSQ you are requesting:

• Total USD: $27,200
• BSQ requested: $27,200 / $0.81 = 33580
• Proposal transaction ID: 30e4147c5bb9c8c271fce803ec65cac95d719d6b2eeb11ec79694f9f0a996a7a

The worked delivered below is the result of around 230 hours of full-time development work that began at the end of Cycle 7. The large focus was on making the P2P layer more robust (fixing bugs), testable (added ~250 test cases), and making it easier to change in the future (comments, javadocs, cleaner design). It concluded with the v1.2.4 testing the ensured it was stable upon release.

I spent the remaining time split between compensated work (triaging incoming bugs/code reviews) and non-compensated work (keybase questions, new dev onboarding, dev process feedback, writing proposals).

Overall, it has been a positive experience contributing to Bisq and I hope the community agrees that my work has been valuable to the project. Don't hesitate to get in touch if you have questions or comments.

Contributions delivered

Provide links to contributions you have delivered, the amount of BSQ you are requesting for each, and any comments that will help stakeholders understand its value.

Testing Efforts (v1.2.4) $2,000

Bugs Filed
TestPad Report

As this was the first time through the manual testing release cycle, I was able to identify a few nice-to-haves for future testing, validate known customer pain points, and reproduce some user-submitted bugs so that the fixes could make it into the release.

Development Efforts $25,200

The development work focused on the P2P layer. It started with full unit testing of the P2PDataStorage code that identified numerous edge case bugs and performance issues that were delivered in this cycle. The work was very incremental so it should be easy to parse for anyone interested in how or why I made the changes.

Overall, I am very happy with the end state of the code. I believe that the next dev who needs to work with it can do so in a much safer environment and get better feedback about their changes.

Feature Development [$5000]

• Phase 1 of Compensation Request Proposals not deleted as expected

This work involved full testing of the P2P synchronization path (even between multiple instances of P2PDataStorage) that identified multiple bugs and performance issues that were delivered as part of the cycle.

Bug Fixes [$9750]

Full bug dump after my review and testing of P2PDataStorage can be found here. It lays out what I found, which Pull Requests addressed the various issues, and which items are still outstanding.

P2PDataStorage Audit Fixes [$6000]

• Misuse of remove() instead of removeMailboxData in P2PService
• Remove messages with non-increasing sequence numbers are accepted
• Add messages with non-increasing sequence numbers are accepted
• addProtectedStorageEntry() returns true when no state is changed
• onDisconnect path not correctly removing PersistablePayloads
• Invalid ProtectedStorageEntry (bad receiversPubKey) isn't validated
• Remove messages seen before Adds were not handled correctly
• TempProposal objects not properly persisted

Incorrect Key Usage Bugs [$3000]

• Duplicate map Entrys due to incorrect 20 vs. 32-byte keys
• Client node receiving duplicate Payloads on GetUpdatedDataRequest

Other Individual Bugs [$750]

• ($750) FileManager audit and delay bug

Performance Work [$1500]

• Remove onBatch interfaces in P2PDataStore | Node becomes unresponsive causing all peers to be dropped bisq#3143

Code Quality [$8000]

Unit testing of P2PDataStorage and associated objects that increased code coverage dramatically and added over 250 tests. This was required to ensure the bug fixes had regression tests and that all changes were done safely. All future changes to this code will be much easier due to the additional safety net these tests now provide.

v1.2.3

master 12-11-19

• (1/8) [TESTS] Add tests for P2PDataStorage in order to safely refactor bisq#3554
• (3/8) [REFACTOR] P2PDataStore::add/remove/refresh bisq#3557
• (5/8) Test P2PDataStore expiration code and make testing time sensitive code easier. bisq#3568
• (6/8) Remove mutating functions of ProtectedStorageEntry bisq#3582
• (7/8) Develop APIs for ProtectedStorageEntry to enable testing and code refactoring bisq#3583
• (8/8) Clean up integration tests now that Entrys are mockable bisq#3584
• (9/9) [PR COMMENTS] Split up P2PDataStoreTest bisq#3587

Code Reviews [$600]

• ($100) PaymentAccount object removal from ObservableSet issue bisq#3572 | revolut/uphold account - unable to remove after creation bisq#3461
• ($125) Fix resource leak caused by not cleaning up unused threads bisq#3734
• ($125) Add Makefile for automating localnet setup bisq#3718
• ($250) Add transient tx map to DaoState to speed up getTx queries bisq#3773

Bug Triage [$350]

• ($100) BSQ balances are shown in BTC bisq#3672
  • Manual bisection of bug to identify bad commits
• ($250) ConcurrentModificationException FileManager::saveToFile bisq#3752
  • Only includes the initial work to verify it was not a regression and non-critical. All work related to the fix would go into the cycle where the fix was delivered.

Contributions in progress

Provide links to work you're involved with that is still in progress. This section is optional, and is for your own benefit in keeping track of what you're doing and keeping other contributors up to date with the same.

Development Efforts

Feature Development

• Compensation Request Proposals not deleted as expected

Roles performed

N/A

Provide links to your monthly report on any roles you are responsible for.

[MwithM]

Closed as accepted