Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For December 2017 #21

Closed
ripcurlx opened this issue Dec 12, 2017 · 6 comments
Closed

For December 2017 #21

ripcurlx opened this issue Dec 12, 2017 · 6 comments
Assignees

Comments

@ripcurlx
Copy link
Contributor

ripcurlx commented Dec 12, 2017

Basic information

Specify the amount of BSQ you are requesting, and the BSQ address that amount should be paid to:

  • BSQ amount requested: 12500
  • BSQ address: B1Dj1kAGDs4AGh83cPFJBQC7pDubtuZV2ZS

Details

Provide links to the work you are requesting compensation for, along with any comments or explanations that will help stakeholders understand its value.

Development/UX

Finally I was able to start working more and more on the Bisq app itself and am committing UI-improvements and small bug fixes at the moment which will be released soon. General moderation of #ux channel.

[1] bisq-network/bisq#1065
[2] bisq-network/bisq#1091
[3] bisq-network/bisq#1097
[4] bisq-network/bisq#1112
[5] bisq-network/bisq#1113

Testing

Testing for release v0.6.2

Growth

bisq-network/roles#42

Analytics

bisq-network/roles#40

Bitcoin Fullnode Operator

Maintenance of full core node btc.christophatteneder.com:8333 and adding of hidden tor service.

Other

Communication with contributors

@ripcurlx ripcurlx changed the title [DRAFT] For December 2017 For December 2017 Dec 28, 2017
@cbeams
Copy link
Member

cbeams commented Jan 4, 2018

This request has been entered into the 2017.12 tab of the BSQ stake and voting spreadsheet and is ready to be voted on.

@cbeams
Copy link
Member

cbeams commented Jan 7, 2018

I've voted +1 for this compensation request, but want to mention / ask about bisq-network/bisq#1091 bisq-network/bisq#1097, which have been merged to the UI-improvements but (so far as I understand) have not been merged to master. What do you think, @ripcurlx and @ManfredKarrer about how this fits with the idea of filing compensation requests only for completed work? If it's not in master, I'd say it's not complete, i.e. it may never make it in front of users.

@ManfredKarrer
Copy link
Member

The downside with applying that is that there is more pressure to merge things to master (both time wise and risk wise) as the requester is waiting for getting compensated. No strong/clear opinion on that...

@ripcurlx
Copy link
Contributor Author

ripcurlx commented Jan 8, 2018

Yes, I guess it depends how we want to have the workflow in the end. If we’ll have a development branch that has stuff in it that needs to be more tested before merged into master I think we could also include pull requests that are not merged into master yet. If we only want to have a master branch and everything that is committed into it has to be release ready than we might not include pull requests that are not merged into master in compensation requests.

@sqrrm
Copy link
Member

sqrrm commented Jan 8, 2018

I think the requirement of only compensating for merges to master might be too strict. For now I'll be voting yes for reasonable looking contributions. Could be that adds too much of a requirement to check the compensation requests though, the ones merged to master are guaranteed to be reviewed and accepted as good contributions.

@cbeams
Copy link
Member

cbeams commented Jan 31, 2018

Closing as complete. See bisq-network/dao#26.

@cbeams cbeams closed this as completed Jan 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants