Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment Variables #2

Open
Bumbledebee opened this issue Oct 20, 2013 · 5 comments
Open

Environment Variables #2

Bumbledebee opened this issue Oct 20, 2013 · 5 comments

Comments

@Bumbledebee
Copy link
Collaborator

The key and secret needs to be stored in environment variables and not to be seen publicly on the github pages anymore. (maybe use new ones as otherwise one can see the history?)

@thatbettina
Copy link
Collaborator

We need to get production keys too.

On Sun, Oct 20, 2013 at 9:11 PM, Debora Blass notifications@github.comwrote:

The key and secret needs to be stored in environment variables and not to
be seen publicly on the github pages anymore. (maybe use new ones as
otherwise one can see the history?)


Reply to this email directly or view it on GitHubhttps://github.com//issues/2
.

Bettina Shzu-Juraschek
Fuldastraße 19-20
12045 Berlin

+49 (0)163 164 7045
bettina.shzu@gmail.com

@birtona
Copy link
Owner

birtona commented Oct 20, 2013

Could you implement the storage of the keys, debbie, or if not, just delete them?
Maybe with the production keys we should wait until further improvement, now it's still too much demo, without even the contact form working ...
And something differerent: did you get the invitations to our new asana project?

@thatbettina
Copy link
Collaborator

I think we should wait to store the production keys when the platform
actually works.

I don't know if I will have time to code before Hamburg. Does anyone else
have time to code--maybe there could be a regular weekly session or
something?

I did not get the invite to the Asana project--is it for this project?

On Sun, Oct 20, 2013 at 9:33 PM, Birte notifications@github.com wrote:

Could you implement the storage of the keys, debbie, or if not, just
delete them?
Maybe with the production keys we should wait until further improvement,
now it's still too much demo, without even the contact form working ...
And something differerent: did you get the invitations to our new asana
project?


Reply to this email directly or view it on GitHubhttps://github.com//issues/2#issuecomment-26680580
.

Bettina Shzu-Juraschek
Fuldastraße 19-20
12045 Berlin

+49 (0)163 164 7045
bettina.shzu@gmail.com

@Bumbledebee
Copy link
Collaborator Author

I think when implementing we should use new keys and delete the old keys in the xing developer account, as the old keys are visible in the github history.
anyways yes wait for the production key thing.

@lieblingswelt
Copy link
Collaborator

Hey, I am incredibly new to all of this, but I somehow got a mailform to
work.
Would like you to take a look at it, Birte. It is not fully functional
as to the dynamic mail recipient, so I didnt want to push, yet. Maybe we
can briefly talk at tonights Ruby User group ?

Am 28.10.13 20:17, schrieb Debora Blass:

I think when implementing we should use new keys and delete the old
keys in the xing developer account, as the old keys are visible in the
github history.
anyways yes wait for the production key thing.


Reply to this email directly or view it on GitHub
#2 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants