Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corpus: update domain when changing used text features #1017

Open
ajdapretnar opened this issue Nov 2, 2023 · 0 comments
Open

Corpus: update domain when changing used text features #1017

ajdapretnar opened this issue Nov 2, 2023 · 0 comments

Comments

@ajdapretnar
Copy link
Collaborator

Describe the bug
Apparently, Corpus never updated the output domain, when the user changed the used text features list.

To Reproduce
Steps to reproduce the behavior:

  1. Corpus, load grimms-tales-selected.
  2. Changed the used text feature to Abstract.
  3. Inspect the output domain with Python Script. Or try to save the Corpus with Save Data. You will see Abstract is never registered as used text feature.

Expected behavior
The user can save the corpus exactly as it is presented in the widget.

Orange version:
3.36.dev

Text add-on version:
1.14.dev

Additional context
Updating the domain would help us get rid of Corpus properties, which is an additional bonus.
ATM, the workaround for the bug is using Edit Domain (less elegant and not as intuitive).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant