Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps are only applying for light theme (dark icon) #760

Open
hrqmonteiro opened this issue Apr 15, 2023 · 3 comments
Open

Apps are only applying for light theme (dark icon) #760

hrqmonteiro opened this issue Apr 15, 2023 · 3 comments

Comments

@hrqmonteiro
Copy link

Specifications

  • Hardcode-Tray version : `` latest
  • Distribution : `` Fedora 37
  • Gtk version : `` 4
  • Inkscape version : `` latest
  • Cairo version : `` latest
  • Sni-qt version: `` latest
  • Application name : `` Joplin, Discord, Steam (not working)
  • Application version : `` latest

Expected behavior and actual behavior

Themes are only applying for light theme (dark icon)

Steps to reproduce the problem

Just trying to apply using Papirus theme, the icons are patched correctly but only uses the dark icons (light theme)

On a dark wallpaper it's impossible to see it:
Screenshot from 2023-04-15 17-30-17

Here's on a light wallpaper:
Screenshot from 2023-04-15 17-31-56

So how can i properly apply the Papirus Dark and Light icons?

@hrqmonteiro
Copy link
Author

This is very strange, even if i pass Papirus-Dark to BOTH themes, like so:

sudo -E hardcode-tray --conversion-tool Inkscape --light-theme Papirus-Dark --dark-theme Papirus-Dark --only joplin

It still changes to a dark icon:

Screenshot from 2023-04-15 17-44-14

Why??

@rauldipeas
Copy link
Contributor

Try this...

sudo hardcode-tray --apply --theme Papirus-Dark

It's working great here with all converted icons, I'm using Kubuntu.

@hrqmonteiro
Copy link
Author

Try this...

sudo hardcode-tray --apply --theme Papirus-Dark

It's working great here with all converted icons, I'm using Kubuntu.

You probably are not getting what i am saying, my man.

If i apply --theme Papirus-Dark, then all of the icons will be white, of course.

What i meant is thatt, when you apply both --light-theme and --dark-theme, it should be theme-aware, right? If ai am on a dark theme, it should use the icons applied on --dark-theme, if i am on a light theme, it should use icons applied on --light-theme. But it doesn't.

If i apply like i said, all of the icons are from the --light-theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants