Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Non-functional corner leveling using a probe #2849

Closed
radek8 opened this issue Sep 29, 2023 · 8 comments · Fixed by #2873 · May be fixed by #2825
Closed

[BUG] Non-functional corner leveling using a probe #2849

radek8 opened this issue Sep 29, 2023 · 8 comments · Fixed by #2873 · May be fixed by #2825
Labels
bug Something isn't working

Comments

@radek8
Copy link
Contributor

radek8 commented Sep 29, 2023

After four months I updated Marlin, and found I had the same problem as shown here:
MarlinFirmware/Marlin#26171

The SERIAL_FLOAT_PRECISION option no longer works in Marlin.
The TFT display is no longer able to analyze the values from the leveling probe due to the format of the value sent by the Marlin.
When leveling and straightening corners with a probe, the measured values are not displayed.
Would someone look into this and fix the problem?
Thank you

Hardware Variant

TFT 35 E3 V3.0

TFT Firmware Version & Main Board Firmware details

current TFT Firmware
current version Marlin 2.1 bugfix

@radek8 radek8 added the bug Something isn't working label Sep 29, 2023
@kisslorand
Copy link
Contributor

I already made several PRs in Marlin repository but they haven't merged any PRs since 26th of August 2023.

@radek8
Copy link
Contributor Author

radek8 commented Sep 29, 2023

Thank you @kisslorand
I'll test your fix tomorrow.

@radek8
Copy link
Contributor Author

radek8 commented Sep 30, 2023

PR #2825
did not solve this problem.

@kisslorand
Copy link
Contributor

kisslorand commented Oct 1, 2023

BTW, this bug is not because of the "SERIAL_FLOAT_PRECISION" not being applied in Marlin but because the syntax of the response of G30 has changed and as a result of it the TFT cannot recognize it.
It's one of the fixes in PR #2825.

@radek8
Copy link
Contributor Author

radek8 commented Oct 2, 2023

Thank you for the explanation.
After editing, your PR is functional.

@kisslorand
Copy link
Contributor

BTW, my PRs regarding the "SERIAL_FLOAT_PRECISION" and G30 response precision has been merged into Marlin.

@rondlh
Copy link

rondlh commented Oct 9, 2023

@radek8 Be careful with Kisslorand, he is not a reliable player and has done several attempts to sabotage this software repository. I'm not sure what his target is, perhaps ransomware, so be sure to not install any firmware from other sources. Be warned!

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
3 participants