Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Optimized Print menu and List/thumbnail selection addition to top row #1572

Closed
sarvenn opened this issue Jan 27, 2021 · 17 comments
Closed
Labels
enhancement New feature or request

Comments

@sarvenn
Copy link

sarvenn commented Jan 27, 2021

Is your feature request related to a problem? Please describe.
Current thumbnail view only shows 5 boxes (files/folders). Up and down buttons doesn't shot up/down but left right and they are too big, back button as well. So these buttons may be optimized and placed on the right column just like "feature" menu.
This will let us to see 6 boxes at this page.
Other suggestion will let us to switch between list and thumbnail view quickly without the need to go to feature menu to change the view selection. (influenced by #1563 )

Describe the solution you'd like
See the picture
Capture

@sarvenn sarvenn added the enhancement New feature or request label Jan 27, 2021
@radek8
Copy link
Contributor

radek8 commented Jan 30, 2021

It seems like a good idea.
The menu for selecting a file for printing would be unified
I would place the button at the top to switch the mode in the upper right corner.
The temperature is not displayed here.

@radek8
Copy link
Contributor

radek8 commented Jan 30, 2021

@kisslorand , should you take the time and mood to handle this?

@sarvenn
Copy link
Author

sarvenn commented Jan 30, 2021

unified

Thanks @radek8. I would be happy if this attracts a developer.
Let me correct a point.
In print selection screen, temperature values (if selected persistant temp reading is on in feature menu) are shown on the upper right corner if thumnail view is enabled, temp values can not be seen at file list view, that's why I placed the file/thumbnail selection button in the upper middle section. That's another open point I discovered now :) why not showing temp values in file list view option? Any logic behind? If not, then it is also something to be improved by the way.

@sarvenn
Copy link
Author

sarvenn commented Jan 30, 2021

20210130_161734
20210130_161738
20210130_161801

@radek8
Copy link
Contributor

radek8 commented Jan 30, 2021

You are right, in one window the temperature icons will not appear in the other yes. This window was just forgotten :-).
Another switching option would be to briefly hold down the "up arrow" or "down arrow" button

@kisslorand
Copy link
Contributor

kisslorand commented Jan 30, 2021

Any logic behind?

Yes, there is a logic to that, in fact there's an explanation.
The two types of files display use two different types of defined menu type. One is using MENU_TYPE_ICON and the other MENU_TYPE_LISTVIEW.
MENU_TYPE_ICON has a title bar zone defined and all menus of this type will display the temperatures if "Persistent Temperature Info" is enabled.

Regarding the idea of 6 icons and navigation buttons on the right...
Implementing this needs a lot of work because the menu type would fall off the MENU_TYPE_ICON definition. Again, the amount of work needed outweighs the benefit of having one more file displayed.

@sarvenn
Copy link
Author

sarvenn commented Jan 30, 2021

I think I understood the point.
My idea is something similar to combine the list and icon view somehow. So there would be a significant work load to combine them, defining the touch zones etc., right?
What if someone take his/her time and doesn't rush to do this? Technically, could it be achievable?

@kisslorand
Copy link
Contributor

Technically, could it be achievable?

Yes, absolutely!

@radek8
Copy link
Contributor

radek8 commented Jan 30, 2021

Thank you

@sarvenn
Copy link
Author

sarvenn commented Jan 31, 2021

So is it possible to add this idea to FR list @oldman4U . Maybe it attracts a developer who is not in hurry to do this. It may take too much effort but I believe it would worth it. I use the thumbnail view most of the time and those big buttons too bad for smaller screens like tft35.

@oldman4U
Copy link
Contributor

It is already.

@oldman4U
Copy link
Contributor

oldman4U commented Feb 5, 2021

Please help the community and close the ticket once you do not need it anymore. Thank you

@sarvenn sarvenn closed this as completed Feb 5, 2021
@sarvenn
Copy link
Author

sarvenn commented Feb 5, 2021

I hope a developer will take this into his/her backlog to do in the near future :)

@sarvenn
Copy link
Author

sarvenn commented Mar 5, 2021

@oldman4U , @bigtreetech should I re-open this and wait for a PR and merge to close it or should it stay closed since the item is added to feature list? #1170

@oldman4U
Copy link
Contributor

oldman4U commented Mar 5, 2021

PRs can be merged completely independent of the existence of a ticket. It also does not matter if it is opened or closed.

@bttguy
Copy link

bttguy commented Aug 31, 2021

+1 from me, would be very cool

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants