Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] In Terminal, move the letter F from the ABC page to 123 page #1181

Closed
StarNamer opened this issue Oct 16, 2020 · 14 comments · Fixed by #1231
Closed

[FR] In Terminal, move the letter F from the ABC page to 123 page #1181

StarNamer opened this issue Oct 16, 2020 · 14 comments · Fixed by #1231
Labels
enhancement New feature or request

Comments

@StarNamer
Copy link

Is your feature request related to a problem? Please describe.
I've recently refitted my 3DTouch a couple of times and each time needed to type the command G1 F60 Z0. But 'F' is on the alphabetic screen so requires 3 screen taps instead of 1.

Describe the solution you'd like
Move the ABC to bottom right and move the SPACE down to where ABC was. Move Z to where SPACE was. Move E to where Z was. Add F where E was.

Also rearrange ABC screen similarly and duplicate E, S & T so they are available of both screens since these are common letters in text.

1 2 3 M G DEL
4 5 6 X Y Z
7 8 9 E F SPC
. 0 - S T ABC

A B C D E DEL
H I J K L N
O P Q R S SPC
T U V W Y 123

Describe alternatives you've considered
Keep switching back and forth between screens

Additional context
There is space for the additional F key on the numeric screen and it is commonly used in GCode commands

@StarNamer StarNamer added the enhancement New feature or request label Oct 16, 2020
@oldman4U
Copy link
Contributor

Hi.

As far as I know, you are a very good programmer. Why not changing it and push a PR?

@oldman4U
Copy link
Contributor

I started a FR list which covers all the requests from the past. Please close this ticket and let me know if you are going to change this or not, so I can mark it correctly.

Thank you

@oldman4U
Copy link
Contributor

I did my part, seems you are working also on it;-)

The FR list is now pinned, so it is easily to see all FR. Please check #1170 and let me know.

Thank you

@StarNamer
Copy link
Author

StarNamer commented Oct 20, 2020

@oldman4U I've actually produced a version which has the F key on the 123 page. But since I have a TFT35 I went a bit further and added I, J, P & R as well by adding an extra column. See this commit.

However, it occurred to me that the TFT24 etc may not be able to reasonably support a 7 by 4 grid of keys. Should I produce a simpler version or just submit a PR for this?

@oldman4U
Copy link
Contributor

Hi.

Sorry, I am no developer, so I asked someone from the dev. team to help. Hope this will happen.

THANK YOU

@StarNamer
Copy link
Author

@oldman4U Thanks. I submitted a PR anyway.

@oldman4U
Copy link
Contributor

Saw it, GREAT!

@guruathwal
Copy link
Contributor

increasing the grid cell count is not good for small displays like TFT24 because the touch does not work well near the edges. There is an empty cell on the first keyboard view. you can use it to place the required F alphabet.

@oldman4U
Copy link
Contributor

Thank you Gurmeet.

I have ordered a TFT24 to see how it works. But I can see that the current solution is already very small on the TFT28 and adding an extra column makes it almost unusable. Don't think this be much better on the 24...;-(

I believe it would be a good idea to take Gurmeets approach and add F to the first page and not to add an extra column.

@StarNamer
Copy link
Author

As I commented on the PR I've already started looking at varying the grid size depending on screen size (320x240, 480x320, etc). I am currently thinking of 6x4 (as now + F) for the 320x### sizes and 7x4 for the 480x### sizes. The TFT70 (800x480) could probably just have a 10x6 and only 1 page!

@oldman4U
Copy link
Contributor

This sounds great. Is your PR complete and is there anything I could test for you?

@StarNamer
Copy link
Author

I've coded a version with different layouts for different screen sizes, but am still testing and know I need to make a few more changes to clean up the code and make it maintainable going forward. At the moment the TFT70 layout would be 10x5, but since the only punctuation which anyone might use outside of filenames is "!" & "#" for M32, I don't see any point in adding any more than I have unless someone asks.

I hope to push a new commit and hence update this PR in the next couple of days - real work and outside life permitting!

By the way, I'm very interested in PR #1171, Ability to Scroll GCode Command Display Window #1112
and am trying make sure there are no conflicts with that.

@oldman4U
Copy link
Contributor

oldman4U commented Nov 8, 2020

Hello StarNamer.

Thank you for your contribution. Today I found some time to check it on the 24,28 and 35 TFT's I have and wanted to send you the attached pictures.

Would be great if you could find some time for additional contributions.

Kind regards

PS: Maybe you want to close this ticket;-)
IMG_7419
IMG_7420

Copy link

github-actions bot commented Apr 3, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants