Skip to content

Commit

Permalink
feat(common): APPEX-314 fix heroku deploy
Browse files Browse the repository at this point in the history
  • Loading branch information
bc-chaz committed Jun 27, 2022
1 parent a9a905b commit 434a782
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 69 deletions.
7 changes: 4 additions & 3 deletions .github/workflows/validate-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,19 @@ jobs:

strategy:
matrix:
node-version: [10.x]
node-version: [12.x, 14.x, 16.x]

steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3

- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}

- name: Install Dependencies
run: npm i -g npm@8.13.1
run: npm ci

- name: Run Build
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ This demo includes all of the files necessary to get started with a basic, hello

To get the app running locally, follow these instructions:

1. [Use Node 10+ and NPM 7+](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm#checking-your-version-of-npm-and-node-js)
1. [Use Node 12+ and NPM 7+](https://docs.npmjs.com/downloading-and-installing-node-js-and-npm#checking-your-version-of-npm-and-node-js)
2. Install npm packages
- `npm install`
3. [Add and start ngrok.](https://www.npmjs.com/package/ngrok#usage) Note: use port 3000 to match Next's server.
Expand Down
63 changes: 0 additions & 63 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"author": "",
"license": "ISC",
"engines": {
"node": ">=10.13.0 <17",
"npm": ">=7.20.x <8.1.4"
"node": ">=12.1.0 <19",
"npm": ">=7.20.x <8.14"
},
"dependencies": {
"@bigcommerce/big-design": "^0.30.2",
Expand Down

0 comments on commit 434a782

Please sign in to comment.