feat(component): tooltip for dropdown item #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems anti-pattern. Is this something already approved by design? I'm out of the loop. |
|
@jorgemoya we talked with Steven, and he said this would be a good-to-have pattern. Specifically, if a button is disabled in a dropdown, it'll give initial feedback for a user on why they can't click it. |
|
@jorgemoya as Chance said, this is described in Shared Variant Options feature's design, so Steven is aware of this. |
deini
reviewed
Nov 4, 2019
deini
reviewed
Nov 4, 2019
chanceaclark
reviewed
Nov 4, 2019
deini
reviewed
Nov 5, 2019
jorgemoya
reviewed
Nov 5, 2019
chanceaclark
reviewed
Nov 5, 2019
chanceaclark
force-pushed
the
CATALOG-5102
branch
from
903d007
to
1f8c55a
Compare
chanceaclark
reviewed
Nov 6, 2019
chanceaclark
force-pushed
the
CATALOG-5102
branch
from
67d32a6
to
0bac4e0
Compare
deini
reviewed
Nov 6, 2019
chanceaclark
force-pushed
the
CATALOG-5102
branch
from
0bac4e0
to
87d1607
Compare
deini
approved these changes
Nov 6, 2019
|
Don't merge till #234 is merged. |
jorgemoya
approved these changes
Nov 6, 2019
chanceaclark
force-pushed
the
CATALOG-5102
branch
from
87d1607
to
8a154f6
Compare
chanceaclark
force-pushed
the
CATALOG-5102
branch
from
8a154f6
to
5263deb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for tooltip in
<Dropdown />component item.