Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: convert to react@18 only #1044

Merged
merged 3 commits into from
Nov 22, 2022
Merged

feat: convert to react@18 only #1044

merged 3 commits into from
Nov 22, 2022

Conversation

chanceaclark
Copy link
Contributor

@chanceaclark chanceaclark commented Nov 21, 2022 •
edited
Loading

What?

Converts BigDesign to be react@18 only.

ℹ️ Reviewing by commit will be helpful!

BREAKING CHANGE:
Requires react@18 or higher.

Why?

So we can get the benefits of SSR react using the new useId hooks.

Screenshots/Screen Recordings

N/A

Testing/Proof

  • Flipped on strict mode to test if there were some concurrency issues, but didn't look like it. Had to flip back off because react-beautiful-dnd doesn't work with strict mode.
  • Manual tested some components
  • Updated snapshots

@chanceaclark
feat(icons): convert icons to react@18 only
a431e54 
BREAKING CHANGE:
Requires `react@18` or higher.
@chanceaclark
feat(theme): convert theme to react@18 only
2ace635 
BREAKING CHANGE:
Requires `react@18` or higher.
@chanceaclark
feat(component): convert components to react@18 only
856a92a 
BREAKING CHANGE:
Requires `react@18` or higher.
@chanceaclark chanceaclark changed the title Chore/react 18 only feat: convert to react@18 only Nov 21, 2022
@chanceaclark chanceaclark marked this pull request as ready for review November 21, 2022 22:24
@chanceaclark chanceaclark requested review from a team as code owners November 21, 2022 22:24
jorgemoya
jorgemoya approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@jorgemoya jorgemoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has there been any discussion in replacing react-beautiful-dnd?

deini
deini approved these changes Nov 21, 2022
View reviewed changes
packages/docs/pages/_app.tsx
Comment on lines -93 to -94
<UIDReset>
<UIDFork>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💭

@chanceaclark
Copy link
Contributor Author

Has there been any discussion in replacing react-beautiful-dnd?

We have had chats about every so often offline, but we should have a better discussion here on GitHub.

@chanceaclark chanceaclark merged commit 06c4697 into bigcommerce:master Nov 22, 2022
@chanceaclark chanceaclark deleted the chore/react-18-only branch November 22, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorgemoya jorgemoya jorgemoya approved these changes

@deini deini deini approved these changes

@MariaJose MariaJose MariaJose approved these changes

@slsriehl slsriehl Awaiting requested review from slsriehl slsriehl was automatically assigned from bigcommerce/dev-docs-team

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chanceaclark @jorgemoya @deini @MariaJose