Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

AnitaLiu98
Copy link

Fix the issue where solutions generated after executing the bash script are not being saved.

Fix the issue where solutions generated after executing the bash script are not being saved.
@loubnabnl
Copy link
Collaborator

The generations are saved by default in the generation_only mode

evaluator.save_json_files(

@Vipitis
Copy link

Vipitis commented Mar 21, 2024

I am also experiencing this. If you set --generation_only and --save_generations_path "./gens.json" but not --save_generations It does not write to file. Several examples and the README should be adjusted, else work might be lost.

problematic behaviour is this line:

if self.args.save_generations:

seems like an easy fix would be setting

self.args.save_generations = True if self.args.generations_only else self.args.save_generations

Or

if self.args.save_generations or self.args.generation_only:

@loubnabnl
Copy link
Collaborator

Ah I missed that, feel free to open a PR that adds if self.args.save_generations or self.args.generation_only: @Vipitis . Thanks!

@Vipitis
Copy link

Vipitis commented Mar 27, 2024

Ah I missed that, feel free to open a PR that adds if self.args.save_generations or self.args.generation_only: @Vipitis . Thanks!

Will do, but won't be able to submit it until next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants