Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropTypes has move to its own package starting React 15.5 #8

Closed
alterx opened this issue Jan 31, 2018 · 3 comments
Closed

PropTypes has move to its own package starting React 15.5 #8

alterx opened this issue Jan 31, 2018 · 3 comments

Comments

@alterx
Copy link
Contributor

alterx commented Jan 31, 2018

PropTypes has moved into it's own package starting with React 15.5+ (https://reactjs.org/blog/2017/04/07/react-v15.5.0.html) so this package is throwing of errors when used with newer versions of React (16, for example).

Change should be pretty straightforward: https://reactjs.org/blog/2017/04/07/react-v15.5.0.html#migrating-from-reactproptypes

Are you accepting PRs?

@bietkul
Copy link
Owner

bietkul commented Jan 31, 2018

Yes, It'll be best if you can contribute.

@alterx alterx changed the title PropTypes has move to it's own package starting React 15.5 PropTypes has move to its own package starting React 15.5 Jan 31, 2018
@bietkul
Copy link
Owner

bietkul commented Jan 31, 2018

Thanks I've merged it and updated the package on npm also.

@bietkul bietkul closed this as completed Jan 31, 2018
@alterx
Copy link
Contributor Author

alterx commented Jan 31, 2018

Perfect @bietkul , thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants