Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Materials with Atomic Counter #7030

Closed
DasLixou opened this issue Dec 25, 2022 · 3 comments
Closed

Custom Materials with Atomic Counter #7030

DasLixou opened this issue Dec 25, 2022 · 3 comments
Labels
A-Reflection Runtime information about types A-Rendering Drawing game state to the screen C-Enhancement A new feature

Comments

@DasLixou
Copy link
Contributor

What problem does this solve or what need does it fill?

After #6988 I've questioned myself if it would be also possible to make custom materials use atomic counter for their AsBindGroup, instead of TypeUUID.

What solution would you like?

Make the AsBindGroup derive also increasing the atomic counter, so that lines like

bevy/examples/shader/shader_material.rs

Line 57 in b6066c3

#[uuid = "f690fdae-d598-45ab-8225-97e2a3f056e0"]
don't need to exist anymore.
@DasLixou DasLixou added C-Enhancement A new feature S-Needs-Triage This issue needs to be labelled labels Dec 25, 2022
@james7132
Copy link
Member

james7132 commented Dec 25, 2022 •
edited
Loading

That line is for the TypeUuid derive. It's required to support using it as an asset. The use case is entirely different and definitely needs a stable independent unique ID that is the same across compilations and executions of the same binary. I don't think we can get rid of that without the stable type name as a replacement for TypeUuid.

@james7132 james7132 added A-Reflection Runtime information about types A-Rendering Drawing game state to the screen and removed S-Needs-Triage This issue needs to be labelled labels Dec 26, 2022
@DasLixou
Copy link
Contributor Author

Oh I See.. should this be closed?

@james7132
Copy link
Member

Probably should. I don't think this issue is actionable. Feel free to reopen if there is something tangible we could do to improve our use of UUIDs here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Reflection Runtime information about types A-Rendering Drawing game state to the screen C-Enhancement A new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@james7132 @DasLixou