Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent return types & parameter naming #7

Open
berkay-yalin opened this issue Apr 11, 2023 · 0 comments
Open

Inconsistent return types & parameter naming #7

berkay-yalin opened this issue Apr 11, 2023 · 0 comments

Comments

@berkay-yalin
Copy link
Owner

Inconsistent return types

Some of the distribution functions return a float whilst others return a decimal.Decimal.
All distribution functions should be consistent in their return types.

Inconsistent parameter naming

Inconsistent naming for parameters of various functions where the actual parameters represent the same thing.
For example, InvBinomialCD uses y whereas InvGeometricCD uses area:

https://github.com/berkay-yalin/python-probabilities/blob/d8585c2c41af3152a365e387ccb5b974b265aeca/python_probabilities/distributions_binomial.py#L59-L61

https://github.com/berkay-yalin/python-probabilities/blob/d8585c2c41af3152a365e387ccb5b974b265aeca/python_probabilities/distributions_geometric.py#L30-L35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant