Fix "preload" markup - HSTS rules #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implements the Markup described in the RFC 6797 - correct: "Strict-Transport-Security: max-age=63072000; includeSubDomains; preload" - incorrect: "Strict-Transport-Security: max-age=63072000; includeSubDomains; preload;"
- replaces double-quotes with single-quotes
- updates the "test_hsts()"-Test to match the correct HSTS-requirements
|
Hey @bepsvpt, is anything missing or do I need to add something? Cheers, |
|
@Enaah thanks a lot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR;
the last semicolon was obsolete.
PreStory
Checked my site with this tool and the submission failed because the Markup wasn't correct.
The Required Markup (according to RFC6769):
Strict-Transport-Security: max-age=63072000; includeSubDomains; preloadThe provided Markup from this package:
Strict-Transport-Security: max-age=63072000; includeSubDomains; preload;Conlusion: remove the last
;