Merge pull request mapbox#354 from mapbox/disable-keybindings

disable keybinding if corresponding control is disabled, closes mapbox#265
bensleveritt · Jun 13, 2016 · cc9b454 · cc9b454
2 parents d66773f + c1ab182
commit cc9b454
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/events.js b/src/events.js
@@ -78,20 +78,20 @@ module.exports = function(ctx) {
   var isKeyModeValid = (code) => !(code === 8 || (code >= 48 && code <= 57));
 
   events.keydown = function(event) {
-    if (event.keyCode === 8) {
+    if (event.keyCode === 8 && ctx.options.controls.trash) {
       event.preventDefault();
       api.fire('trash');
     }
     else if (isKeyModeValid(event.keyCode)) {
       currentMode.keydown(event);
     }
-    else if (event.keyCode === 49) {
+    else if (event.keyCode === 49 && ctx.options.controls.point) {
       ctx.api.changeMode('draw_point');
     }
-    else if (event.keyCode === 50) {
+    else if (event.keyCode === 50 && ctx.options.controls.line_string) {
       ctx.api.changeMode('draw_line_string');
     }
-    else if (event.keyCode === 51) {
+    else if (event.keyCode === 51 && ctx.options.controls.polygon) {
       ctx.api.changeMode('draw_polygon');
     }
   };

diff --git a/src/ui.js b/src/ui.js
@@ -96,7 +96,7 @@ module.exports = function(ctx) {
           }
         }
 
-        if (controls.line_string) {
+        if (controls[types.LINE]) {
           buttons[types.LINE] = createButton(controlGroup, {
             className: `${controlClass} mapbox-gl-draw_line`,
             title: `LineString tool ${ctx.options.keybindings && '(l)'}`,