Fix umask option bug(issues#1622) #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hramezani
force-pushed
the
fix_umask_bug
branch
from
b269a58
to
ced208e
Compare
berkerpeksag
requested changes
Oct 26, 2017
There was a problem hiding this comment.
Could you also convert the example shared in #1622 to a test case?
gunicorn/config.py
Outdated
| if x.startswith('0') and not x.lower().startswith('0x'): | ||
| # for compatible with octal numbers in python3 | ||
| # for compatible with octal numbers in python3 | ||
| if re.match('0(\d)', x, re.IGNORECASE): |
There was a problem hiding this comment.
I'd use r'' to avoid subtle bugs.
Closed
hramezani
force-pushed
the
fix_umask_bug
branch
from
ced208e
to
bcfd534
Compare
|
@berkerpeksag thanks, I add those examples to |
|
I think the problem here is that our test code doesn't call |
|
Nevermind, the existing test was wrong. |
tests/test_config.py
Outdated
| @@ -375,6 +375,8 @@ def test_reload(options, expected): | |||
|
|
|||
| @pytest.mark.parametrize("options, expected", [ | |||
| (["--umask 0", "myapp:app"], 0), | |||
There was a problem hiding this comment.
This should read:
(["--umask", "0", "myapp:app"], 0),
tests/test_config.py
Outdated
| @@ -375,6 +375,8 @@ def test_reload(options, expected): | |||
|
|
|||
| @pytest.mark.parametrize("options, expected", [ | |||
| (["--umask 0", "myapp:app"], 0), | |||
| (["--umask 0o0", "myapp:app"], 0), | |||
There was a problem hiding this comment.
Same as above:
(["--umask", "0o0", "myapp:app"], 0),
(["--umask", "0x0", "myapp:app"], 0),
hramezani
force-pushed
the
fix_umask_bug
branch
from
bcfd534
to
d06aaab
Compare
|
@berkerpeksag, thanks, you are right. I fixed the tests |
berkerpeksag
approved these changes
Oct 28, 2017
|
Thanks! |
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix umask option bug. issue_1622