Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL support for gaiohttp worker #1105

Merged
merged 1 commit into from
Aug 25, 2015
Merged

Conversation

tumb1er
Copy link
Contributor

@tumb1er tumb1er commented Aug 25, 2015

Initialize and pass SSLContext to asyncio.loop.create_server to enable ssl support.

Once again - see #1092

Initialize and pass `SSLContext` to `asyncio.loop.create_server` to enable ssl support.
@benoitc
Copy link
Owner

benoitc commented Aug 25, 2015

👍

benoitc added a commit that referenced this pull request Aug 25, 2015
SSL support for gaiohttp worker
@benoitc benoitc merged commit 209a605 into benoitc:master Aug 25, 2015
@benoitc
Copy link
Owner

benoitc commented Aug 25, 2015

thanks!

@tumb1er tumb1er deleted the ssl_gaiohttp branch August 25, 2015 13:47
@berkerpeksag
Copy link
Collaborator

If we have a _create_socket method to make subclassing and customization easier, shouldn't we make it a public method(e.g. without a _ prefix and document its intent in the docstring)?

mjjbell pushed a commit to mjjbell/gunicorn that referenced this pull request Mar 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants