Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it a good idea to always add your CKEditor plugin? #4

Open
josefglatz opened this issue Apr 21, 2020 · 0 comments
Open

Is it a good idea to always add your CKEditor plugin? #4

josefglatz opened this issue Apr 21, 2020 · 0 comments

Comments

@josefglatz
Copy link

This issue is regarding the event listener, which modifies every CKEditor preset.

$configuration['extraPlugins'][] = 'syntax_code';

To my understanding we have the nice possibility to create many CKEditor presets where you can explicitly fine grade what you need. I often have multiple presets with complete different use cases and very different configs to support the backend editor as much as it is possible. With your approach the adoptions are made ALWAYS, no matter how the preset is configured. This often makes sense in smaller TYPO3 projects, but not for enterprise.

So, what do you think about adding at least an extension configuration setting which can be used to disable the default injection of your extension related CKEditor preset adoptions?

I really would like to discuss this on your implementation. Let's find some way to have an example implementation of the used event listener. We can add examples in the rte_ckeditor documentation afterwards too.

@benjaminkott, what are your backgrounds to the currently implemented approach?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant