Return numpy arrays from recommend methods #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change recommend/rank_items/similar_items/similar_users to return a numpy array of ids and a numpy array of scores, rather than return a python list of (itemid, score) tuples. This opens up options for batch processing in the future, and can be trivially converted by users into the previous format (liked ```zip(*model.recommend(...))```.
Closed
6 tasks
benfred
added a commit
that referenced
this pull request
Dec 31, 2021
Change recommend/rank_items/similar_items/similar_users to return a numpy array of ids and a numpy array of scores, rather than return a python list of (itemid, score) tuples. This opens up options for batch processing in the future, and can be trivially converted by users into the previous format (liked ```zip(*model.recommend(...))```.
benfred
added a commit
that referenced
this pull request
Nov 21, 2022
#482 introduced a bug where the output of the knn models wasn't strictly ordered by score. Fix this and add a test that would have caught this bug
benfred
added a commit
that referenced
this pull request
Nov 21, 2022
#482 introduced a bug where the output of the knn models wasn't strictly ordered by score. Fix this and add a test that would have caught this bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change recommend/rank_items/similar_items/similar_users to return a numpy array of ids
and a numpy array of scores, rather than return a python list of (itemid, score) tuples.
This opens up options for batch processing in the future, and can be trivially converted
by users into the previous format (liked
zip(*model.recommend(...)).