Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable project name #44

Merged
merged 14 commits into from
Apr 8, 2022
Merged

Configurable project name #44

merged 14 commits into from
Apr 8, 2022

Conversation

rdnt
Copy link
Contributor

@rdnt rdnt commented Apr 1, 2022

Closes #12

  • If empty, set project name based on the project's absolute filesystem path
  • Validate uniqueness of project name across aggregated bobfiles
  • Project name passed to tasks, so that artifacts can be properly stored if needed (e.g. in a remote store)
  • Playground generation slightly modified to help test the project name

@Equanox
Copy link
Member

Equanox commented Apr 1, 2022

Closes #12

@rdnt rdnt self-assigned this Apr 1, 2022
@rdnt rdnt marked this pull request as ready for review April 1, 2022 12:21
bob/aggregate.go Outdated Show resolved Hide resolved
bob/aggregate.go Outdated Show resolved Hide resolved
bob/bobfile/bobfile.go Show resolved Hide resolved
pkg/store/filestore/filestore.go Outdated Show resolved Hide resolved
bob/aggregate.go Outdated Show resolved Hide resolved
@rdnt rdnt requested a review from Equanox April 8, 2022 10:50
@rdnt
Copy link
Contributor Author

rdnt commented Apr 8, 2022

@Equanox regarding TODO: maybe don't leak absolute path of environment (bob/aggregate.go:108):

Since we will not be syncing projects without a proper remote set up as a project name, there is no possibility to have an absolute path in a remote artifact's metadata. Let me know if I should remove the comment from the code.

@Equanox
Copy link
Member

Equanox commented Apr 8, 2022

@rdnt yes that can be unexpected.. let's keep an eye on it.. though it seems to be save for now.

@Equanox Equanox merged commit 9b86866 into main Apr 8, 2022
@Equanox Equanox deleted the feature/project-name branch April 8, 2022 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Name
2 participants