Merge pull request #2888 from freakboy3742/deprecate-3.8

Deprecate Python 3.8

.github/workflows/ci.yml

@@ -16,7 +16,7 @@ on:
         value: ${{ jobs.package.outputs.artifact-basename }}
 
 env:
-  min_python_version: "3.8"
+  min_python_version: "3.9"
   max_python_version: "3.12"
   FORCE_COLOR: "1"
 
@@ -75,30 +75,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        platform: [ "macos-12", "macos-14", "ubuntu-latest", "windows-latest" ]
-        python-version: [ "3.8", "3.12", "3.13-dev" ]
+        platform: [ "macos-latest", "ubuntu-latest", "windows-latest" ]
+        python-version: [ "3.9", "3.10", "3.11", "3.12", "3.13" ]
         include:
         - experimental: false
-        # Test Python 3.9-3.11 on Ubuntu only
-        - platform: "ubuntu-latest"
-          python-version: "3.9"
-          experimental: false
-        - platform: "ubuntu-latest"
-          python-version: "3.10"
-          experimental: false
-        - platform: "ubuntu-latest"
-          python-version: "3.11"
-          experimental: false
-        # Allow development Python to fail without failing entire job.
-        - python-version: "3.13-dev"
-          experimental: true
-        exclude:
-        # macos-14 (i.e. arm64) does not support Python 3.8
-        - platform: "macos-14"
-          python-version: "3.8"
-        # Pillow isn't available for Python 3.13 on Windows
-        - platform: "windows-latest"
-          python-version: "3.13-dev"
+
     steps:
     - name: Checkout
       uses: actions/checkout@v4.2.0
@@ -109,6 +90,7 @@ jobs:
       uses: actions/setup-python@v5.2.0
       with:
         python-version: ${{ matrix.python-version }}
+        allow-prereleases: true
 
     - name: Install Tox
       uses: beeware/.github/.github/actions/install-requirement@main

.pre-commit-config.yaml

@@ -13,7 +13,7 @@ repos:
     rev: v3.17.0
     hooks:
       - id: pyupgrade
-        args: [--py38-plus]
+        args: [--py39-plus]
   - repo: https://github.com/PyCQA/isort
     rev: 5.13.2
     hooks:

android/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga-android"
 description = "An Android backend for the Toga widget toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -33,7 +33,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

changes/2888.removal.rst

@@ -0,0 +1 @@
+Toga no longer supports Python 3.8.

cocoa/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga-cocoa"
 description = "A Cocoa (macOS) backend for the Toga widget toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -34,7 +34,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

core/README.rst

@@ -10,13 +10,14 @@ install a backend that implements the core Toga API for that platform:
 * **iOS** `toga-iOS <https://pypi.org/project/toga-iOS>`__
 * **Linux** `toga-gtk <https://pypi.org/project/toga-gtk>`__
 * **macOS** `toga-cocoa <https://pypi.org/project/toga-cocoa>`__
+* **Textual** `toga-textual <https://pypi.org/project/toga-textual>`__
 * **Web** `toga-web <https://pypi.org/project/toga-web>`__
 * **Windows** `toga-winforms <https://pypi.org/project/toga-winforms>`__
 
 Minimum requirements
 --------------------
 
-Toga requires **Python 3.8** or newer. Python 2 is not supported.
+Toga requires **Python 3.9** or newer.
 
 Each backend also has specific requirements and pre-requisites. See the `platform
 documentation <https://toga.readthedocs.io/en/latest/reference/platforms.html>`__ for

core/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version"]
 name = "toga-core"
 description = "A Python native, OS native GUI toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -45,7 +45,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",
@@ -69,9 +68,7 @@ dev = [
     "coverage[toml] == 7.6.1",
     "coverage-conditional-plugin == 0.9.0",
     "Pillow == 10.4.0",
-    # Pre-commit 3.6.0 deprecated support for Python 3.8
-    "pre-commit == 3.5.0 ; python_version < '3.9'",
-    "pre-commit == 4.0.0 ; python_version >= '3.9'",
+    "pre-commit == 4.0.0",
     "pytest == 8.3.3",
     "pytest-asyncio == 0.24.0",
     "pytest-freezer == 0.4.8",

core/src/toga/command.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-from collections.abc import Iterator
-from typing import TYPE_CHECKING, MutableMapping, MutableSet, Protocol
+from collections.abc import Iterator, MutableMapping, MutableSet
+from typing import TYPE_CHECKING, Protocol
 
 from toga.handlers import simple_handler, wrapped_handler
 from toga.icons import Icon

core/src/toga/documents.py

@@ -3,9 +3,9 @@
 import itertools
 import sys
 from abc import ABC, abstractmethod
-from collections.abc import Iterator
+from collections.abc import Iterator, Mapping, Sequence
 from pathlib import Path
-from typing import TYPE_CHECKING, Mapping, Sequence
+from typing import TYPE_CHECKING
 
 import toga
 from toga import dialogs
@@ -225,11 +225,11 @@ def __getitem__(self, path_or_index):
             return self.elements[path_or_index]
 
         # Look up by path
-        if sys.version_info < (3, 9):  # pragma: no-cover-if-gte-py39
+        if sys.version_info < (3, 10):  # pragma: no-cover-if-gte-py310
             # resolve() *should* turn the path into an absolute path;
-            # but on Windows, with Python 3.8, it doesn't.
+            # but on Windows, with Python 3.9, it doesn't.
             path = Path(path_or_index).absolute().resolve()
-        else:  # pragma: no-cover-if-lt-py39
+        else:  # pragma: no-cover-if-lt-py310
             path = Path(path_or_index).resolve()
         for item in self.elements:
             if item.path == path:
@@ -320,11 +320,11 @@ def open(self, path: Path | str) -> Document:
             match a registered document type.
         """
         try:
-            if sys.version_info < (3, 9):  # pragma: no-cover-if-gte-py39
+            if sys.version_info < (3, 10):  # pragma: no-cover-if-gte-py310
                 # resolve() *should* turn the path into an absolute path;
-                # but on Windows, with Python 3.8, it doesn't.
+                # but on Windows, with Python 3.9, it doesn't.
                 path = Path(path).absolute().resolve()
-            else:  # pragma: no-cover-if-lt-py39
+            else:  # pragma: no-cover-if-lt-py310
                 path = Path(path).resolve()
             document = self.app.documents[path]
             document.focus()

core/src/toga/handlers.py

@@ -6,12 +6,11 @@
 import traceback
 import warnings
 from abc import ABC
+from collections.abc import Awaitable, Generator
 from typing import (
     TYPE_CHECKING,
     Any,
-    Awaitable,
     Callable,
-    Generator,
     NoReturn,
     Protocol,
     TypeVar,

core/src/toga/sources/tree_source.py

@@ -1,7 +1,7 @@
 from __future__ import annotations
 
-from collections.abc import Iterator
-from typing import Iterable, Mapping, TypeVar
+from collections.abc import Iterable, Iterator, Mapping
+from typing import TypeVar
 
 from .base import Source
 from .list_source import Row, _find_item

core/src/toga/statusicons.py

@@ -2,8 +2,8 @@
 
 import sys
 from abc import abstractmethod
-from collections.abc import Iterator
-from typing import TYPE_CHECKING, Mapping, Sequence
+from collections.abc import Iterator, Mapping, Sequence
+from typing import TYPE_CHECKING
 
 import toga
 from toga.command import Command, CommandSet, Group

core/src/toga/window.py

@@ -2,9 +2,9 @@
 
 import warnings
 from builtins import id as identifier
-from collections.abc import Coroutine, Iterator
+from collections.abc import Coroutine, Iterator, MutableSet
 from pathlib import Path
-from typing import TYPE_CHECKING, Any, MutableSet, Protocol, TypeVar
+from typing import TYPE_CHECKING, Any, Protocol, TypeVar
 
 import toga
 from toga import dialogs

demo/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga-demo"
 description = "A demonstration of the capabilities of the Toga widget toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -40,7 +40,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

dummy/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga-dummy"
 description = "A dummy testing backend for the Toga widget toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -32,7 +32,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

gtk/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga-gtk"
 description = "A GTK backend for the Toga widget toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -35,7 +35,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

iOS/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga-iOS"
 description = "An iOS backend for the Toga widget toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -33,7 +33,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

pyproject.toml

@@ -42,9 +42,6 @@ no-cover-if-lt-py311 = "sys_version_info < (3, 11) and os_environ.get('COVERAGE_
 no-cover-if-gte-py311 = "sys_version_info > (3, 11) and os_environ.get('COVERAGE_EXCLUDE_PYTHON_VERSION') != 'disable'"
 no-cover-if-lt-py310 = "sys_version_info < (3, 10) and os_environ.get('COVERAGE_EXCLUDE_PYTHON_VERSION') != 'disable'"
 no-cover-if-gte-py310 = "sys_version_info > (3, 10) and os_environ.get('COVERAGE_EXCLUDE_PYTHON_VERSION') != 'disable'"
-no-cover-if-lt-py39 = "sys_version_info < (3, 9) and os_environ.get('COVERAGE_EXCLUDE_PYTHON_VERSION') != 'disable'"
-no-cover-if-gte-py39 = "sys_version_info > (3, 9) and os_environ.get('COVERAGE_EXCLUDE_PYTHON_VERSION') != 'disable'"
-
 
 [tool.isort]
 profile = "black"

textual/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga-textual"
 description = "A Textual backend for the Toga widget toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -34,7 +34,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

toga/pyproject.toml

@@ -11,7 +11,7 @@ dynamic = ["version", "dependencies"]
 name = "toga"
 description = "A Python native, OS native GUI toolkit."
 readme = "README.rst"
-requires-python = ">= 3.8"
+requires-python = ">= 3.9"
 license.text = "New BSD"
 authors = [
     {name="Russell Keith-Magee", email="russell@keith-magee.com"},
@@ -45,7 +45,6 @@ classifiers = [
     "License :: OSI Approved :: BSD License",
     "Operating System :: OS Independent",
     "Programming Language :: Python :: 3",
-    "Programming Language :: Python :: 3.8",
     "Programming Language :: Python :: 3.9",
     "Programming Language :: Python :: 3.10",
     "Programming Language :: Python :: 3.11",

tox.ini

@@ -7,17 +7,15 @@ extend-ignore =
     E203,
 
 [tox]
-# Add Python 3.13 once a wheel for Pillow is available
-envlist = py{38,39,310,311,312}-cov,coverage
+envlist = py{39,310,311,312,313}-cov,coverage
 labels =
     test = py-cov,coverage
-    test38 = py38-cov,coverage38
     test39 = py39-cov,coverage39
     test310 = py310-cov,coverage310
     test311 = py311-cov,coverage311
     test312 = py312-cov,coverage312
     test313 = py313-cov,coverage313
-    ci = towncrier-check,docs-lint,pre-commit,py{38,39,310,311,312}-cov,coverage-fail-platform
+    ci = towncrier-check,docs-lint,pre-commit,py{39,310,311,312,313}-cov,coverage-fail-platform
 skip_missing_interpreters = True
 
 [testenv:pre-commit]
@@ -27,7 +25,7 @@ deps =
 commands = pre-commit run --all-files --show-diff-on-failure --color=always
 
 # The leading comma generates the "py" environment
-[testenv:py{,38,39,310,311,312,313}{,-cov}]
+[testenv:py{,39,310,311,312,313}{,-cov}]
 depends = pre-commit
 changedir = core
 skip_install = True
@@ -42,14 +40,13 @@ commands =
     !cov: python -m pytest {posargs:-vv --color yes}
     cov : python -m coverage run -m pytest {posargs:-vv --color yes}
 
-[testenv:coverage{,38,39,310,311,312,313}{,-html}{,-keep}{,-fail}{,-platform}]
-depends = pre-commit,py{,38,39,310,311,312,313}{,-cov}
+[testenv:coverage{,39,310,311,312,313}{,-html}{,-keep}{,-fail}{,-platform}]
+depends = pre-commit,py{,39,310,311,312,313}{,-cov}
 changedir = core
 skip_install = True
 # by default, coverage should run on oldest supported Python for testing platform coverage.
 # however, coverage for a particular Python version should match the version used for pytest.
 base_python =
-    coverage38: py38
     coverage39: py39
     coverage310: py310
     coverage311: py311