Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageCommand: run verify_app_tools() after other pre-requisite commands #878

Merged
merged 3 commits into from
Sep 27, 2022

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented Sep 27, 2022

Got this wrong even after spending too much time thinking about it....or because I spent too much time.

Changes

The call to verify_app_tools() for PackageCommand now happens after any per-requisite commands are run.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 marked this pull request as ready for review September 27, 2022 21:18
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. From a quick check, publish has the same problem; publish is a no-op, but for the sake of consistency (and future sanity) it's worth cleaning this up now.

I've pushed the update; once CI passes I'm happy for this to land.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #878 (c448367) into main (9ab31c8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted Files Coverage Δ
src/briefcase/commands/package.py 86.04% <100.00%> (ø)
src/briefcase/commands/publish.py 96.66% <100.00%> (+0.51%) ⬆️
src/briefcase/console.py 100.00% <0.00%> (ø)
src/briefcase/integrations/subprocess.py 100.00% <0.00%> (ø)
src/briefcase/commands/new.py 97.01% <0.00%> (+0.02%) ⬆️

@freakboy3742 freakboy3742 merged commit dbfef89 into beeware:main Sep 27, 2022
@rmartin16 rmartin16 deleted the package-verify-app-tools branch January 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants