Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove prefix from build_gradle_dependencies warning #1628

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

rmartin16
Copy link
Member

Changes

  • The new warning for build_gradle_dependencies caught me off guard with the prefix...so, I removed it.
  • Logging these boxed warnings without a prefix is more in line with other uses; feel free to close if you disagree.

Before:

[androidrequests] Generating application template...

[androidrequests] 
[androidrequests] *************************************************************************
[androidrequests] ** WARNING: App does not define build_gradle_dependencies              **
[androidrequests] *************************************************************************
[androidrequests] 
[androidrequests]     The Android configuration for this app does not contain a
[androidrequests]     `build_gradle_dependencies` definition. Briefcase will use a default
[androidrequests]     value of:
[androidrequests] 
[androidrequests]         build_gradle_dependencies = [
[androidrequests]             "androidx.appcompat:appcompat:1.0.2",
[androidrequests]             "androidx.constraintlayout:constraintlayout:1.1.3",
[androidrequests]             "androidx.swiperefreshlayout:swiperefreshlayout:1.1.0",
[androidrequests]         ]
[androidrequests] 
[androidrequests]     You should add this definition to the Android configuration
[androidrequests]     of your project's pyproject.toml file. See:
[androidrequests] 
[androidrequests]         https://briefcase.readthedocs.io/en/stable/reference/platforms/android.html#build_gradle-dependencies
[androidrequests] 
[androidrequests]     for more information.
[androidrequests] 
[androidrequests] *************************************************************************
Using app template: https://github.com/beeware/briefcase-android-gradle-template.git, branch v0.3.17

After:

[androidrequests] Generating application template...

*************************************************************************
** WARNING: App does not define build_gradle_dependencies              **
*************************************************************************

    The Android configuration for this app does not contain a
    `build_gradle_dependencies` definition. Briefcase will use a default
    value of:

        build_gradle_dependencies = [
            "androidx.appcompat:appcompat:1.0.2",
            "androidx.constraintlayout:constraintlayout:1.1.3",
            "androidx.swiperefreshlayout:swiperefreshlayout:1.1.0",
        ]

    You should add this definition to the Android configuration
    of your project's pyproject.toml file. See:

        https://briefcase.readthedocs.io/en/stable/reference/platforms/android.html#build_gradle-dependencies

    for more information.

*************************************************************************

Using app template: https://github.com/beeware/briefcase-android-gradle-template.git, branch v0.3.17

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed this is more readable. +1

@freakboy3742 freakboy3742 marked this pull request as ready for review February 3, 2024 00:04
@freakboy3742 freakboy3742 merged commit 2618510 into beeware:main Feb 3, 2024
46 checks passed
@rmartin16 rmartin16 deleted the no-prefix-warning branch February 3, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants