Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Windows Store Python testing from CI #1538

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

rmartin16
Copy link
Member

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

- The underlying API to download this Python is no longer available to
  GitHub runners
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good; one question about the coverage target change.

@@ -103,7 +92,7 @@ jobs:
id: coverage
if: always() && contains('success,failure', steps.test.outcome)
# coverage reporting must use the same Python version used to produce coverage
run: tox -qe coverage$(echo '${{ matrix.python-version }}' | tr -dc '0-9')
run: tox -qe coverage$(tr -d "." <<< "${{ matrix.python-version }}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't 3.13-dev cause a problem here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes....but that's a problem for whoever adds 3.13 support ;)

I'll restore the slightly more complicated tr

@freakboy3742 freakboy3742 merged commit b3059db into beeware:main Nov 14, 2023
34 checks passed
@rmartin16 rmartin16 deleted the remove-winstore-ci-tests branch November 14, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants