Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the Briefcase version to cookiecutter from NewCommand #1276

Merged
merged 1 commit into from
May 17, 2023
Merged

Pass the Briefcase version to cookiecutter from NewCommand #1276

merged 1 commit into from
May 17, 2023

Conversation

rmartin16
Copy link
Member

@rmartin16 rmartin16 commented May 16, 2023 •
edited
Loading

Changes

  • briefcase new now passes briefcase.__version__ as briefcase_version to cookiecutter so pyproject.toml contains the Briefcase version instead of Unknown

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

@rmartin16 rmartin16 force-pushed the new-with-briefcase-version branch 3 times, most recently from 98eec3f to c3437e5 Compare May 16, 2023 17:17
@rmartin16 rmartin16 marked this pull request as ready for review May 16, 2023 17:37
freakboy3742
freakboy3742 approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 2c9cffa into beeware:main May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rmartin16 @freakboy3742