Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct Python version where UNC path parsing changed #1096

Merged
merged 1 commit into from
Feb 12, 2023
Merged

Correct Python version where UNC path parsing changed #1096

merged 1 commit into from
Feb 12, 2023

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Feb 12, 2023

Correction of #1088. After further testing, it turns out the relevant behavior change was not backported to Python 3.11.2, so I've adjusted the version cutoff to 3.12.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

rmartin16
rmartin16 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Member

@rmartin16 rmartin16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI still isn't running on Python 3.11.2 but tests passed on my local machine.

@freakboy3742 freakboy3742 merged commit 12525af into beeware:main Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

@rmartin16 rmartin16 rmartin16 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhsmith @freakboy3742 @rmartin16