Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass test_sources to Gradle template for extractPackages #1061

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

mhsmith
Copy link
Member

@mhsmith mhsmith commented Jan 25, 2023

See beeware/briefcase-android-gradle-template#60 (comment).

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

Copy link
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a couple of minor tweaks of API usage that are equivalent, but more consistent with the rest of the codebase (pathlib instead of os.path; sys.platform rather than os.name) and added a changenote; but otherwise, looks good.

Passing through extract_packages as a pre-rendered string bugs me a little - outside of literal template inclusions like build_gradle_extra_content, my usual preference is to pass through raw data, rather than pre-rendered template content, so that the template can decide what to do with it. However, cookiecutter makes it painful to pass a list, so we'd need to do something like pass through a dictionary of all sources; while that would work, it feels like overkill. As this won't ever be directly modified by the user, and it's a property that we (through chaquopy) are in control ok, I'm OK with practicality over purity in this case.

@freakboy3742 freakboy3742 merged commit e6954ef into beeware:main Jan 25, 2023
@mhsmith
Copy link
Member Author

mhsmith commented Jan 26, 2023

Thanks: I meant to add a changenote but it looks like I forgot to save the file before committing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants